From 3e8d3d88373b58e76018e7dd7eec6faa3fd08113 Mon Sep 17 00:00:00 2001 From: Jeongmo Yang Date: Tue, 15 Sep 2020 12:23:09 +0900 Subject: [PATCH] Fix coverity issue - Missing unlock [Version] 0.1.20 [Issue Type] Coverity Change-Id: I9a5377d9d8d268a00730f8d0c6be54eada011dc4 Signed-off-by: Jeongmo Yang --- packaging/capi-media-tool.spec | 2 +- src/media_packet_pool.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packaging/capi-media-tool.spec b/packaging/capi-media-tool.spec index a8bda28..c3412a8 100755 --- a/packaging/capi-media-tool.spec +++ b/packaging/capi-media-tool.spec @@ -1,6 +1,6 @@ Name: capi-media-tool Summary: A Core API media tool library in Tizen Native API -Version: 0.1.19 +Version: 0.1.20 Release: 0 Group: Multimedia/API License: Apache-2.0 diff --git a/src/media_packet_pool.c b/src/media_packet_pool.c index b97e184..c2b25c7 100644 --- a/src/media_packet_pool.c +++ b/src/media_packet_pool.c @@ -222,6 +222,7 @@ int media_packet_pool_acquire_packet(media_packet_pool_h pool, media_packet_h *p if (media_packet_create_alloc(pool_handle->fmt_h, _packet_finalize_cb, pool_handle, &pool_handle->packet[pool_handle->curr_pool_size]) != MEDIA_PACKET_ERROR_NONE) { LOGE("The media packet pool is full or out of memory..."); + g_mutex_unlock(&pool_handle->mutex); return MEDIA_PACKET_ERROR_INVALID_OPERATION; } packet = pool_handle->packet[pool_handle->curr_pool_size]; @@ -339,6 +340,7 @@ int media_packet_pool_deallocate(media_packet_pool_h pool) packet = g_queue_pop_head(pool_handle->queue); if (packet == NULL) { + g_mutex_unlock(&pool_handle->mutex); LOGE("Failed to get packet handle from Queue "); //LCOV_EXCL_LINE return MEDIA_PACKET_ERROR_INVALID_OPERATION; } -- 2.34.1