From 3e76d8b870e958e29f3ee779ecdfee1ec5db7a05 Mon Sep 17 00:00:00 2001 From: "dcarney@chromium.org" Date: Wed, 4 Sep 2013 07:05:11 +0000 Subject: [PATCH] remove Isolate::Current from most files starting with 'o' through 'r' R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/23757017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16513 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/api.cc | 11 ++--- src/builtins.cc | 2 +- src/execution.cc | 2 +- src/factory.cc | 4 +- src/ic.cc | 2 +- src/json-stringifier.h | 9 ++-- src/liveedit.cc | 35 +++++++++------ src/log.cc | 2 +- src/objects-debug.cc | 2 +- src/objects-inl.h | 10 ++--- src/objects.cc | 56 ++++++++++-------------- src/objects.h | 19 ++++++--- src/parser.cc | 13 +++--- src/parser.h | 5 ++- src/runtime.cc | 23 +++++----- test/cctest/test-api.cc | 101 ++++++++++++++++++++++---------------------- test/cctest/test-heap.cc | 14 +++--- test/cctest/test-parsing.cc | 7 +-- 18 files changed, 165 insertions(+), 152 deletions(-) diff --git a/src/api.cc b/src/api.cc index 4b80555..e2f3fcd 100644 --- a/src/api.cc +++ b/src/api.cc @@ -1683,19 +1683,20 @@ void ObjectTemplate::SetInternalFieldCount(int value) { ScriptData* ScriptData::PreCompile(const char* input, int length) { i::Utf8ToUtf16CharacterStream stream( reinterpret_cast(input), length); - return i::PreParserApi::PreParse(&stream); + return i::PreParserApi::PreParse(i::Isolate::Current(), &stream); } ScriptData* ScriptData::PreCompile(v8::Handle source) { i::Handle str = Utils::OpenHandle(*source); + i::Isolate* isolate = str->GetIsolate(); if (str->IsExternalTwoByteString()) { i::ExternalTwoByteStringUtf16CharacterStream stream( i::Handle::cast(str), 0, str->length()); - return i::PreParserApi::PreParse(&stream); + return i::PreParserApi::PreParse(isolate, &stream); } else { i::GenericStringUtf16CharacterStream stream(str, 0, str->length()); - return i::PreParserApi::PreParse(&stream); + return i::PreParserApi::PreParse(isolate, &stream); } } @@ -2289,7 +2290,7 @@ Local StackTrace::GetFrame(uint32_t index) const { ENTER_V8(isolate); HandleScope scope(reinterpret_cast(isolate)); i::Handle self = Utils::OpenHandle(this); - i::Object* raw_object = self->GetElementNoExceptionThrown(index); + i::Object* raw_object = self->GetElementNoExceptionThrown(isolate, index); i::Handle obj(i::JSObject::cast(raw_object)); return scope.Close(Utils::StackFrameToLocal(obj)); } @@ -3362,7 +3363,7 @@ Local v8::Object::Get(uint32_t index) { ENTER_V8(isolate); i::Handle self = Utils::OpenHandle(this); EXCEPTION_PREAMBLE(isolate); - i::Handle result = i::Object::GetElement(self, index); + i::Handle result = i::Object::GetElement(isolate, self, index); has_pending_exception = result.is_null(); EXCEPTION_BAILOUT_CHECK(isolate, Local()); return Utils::ToLocal(result); diff --git a/src/builtins.cc b/src/builtins.cc index 7118121..b481483 100644 --- a/src/builtins.cc +++ b/src/builtins.cc @@ -594,7 +594,7 @@ BUILTIN(ArrayPop) { if (accessor->HasElement(array, array, new_length, elms_obj)) { maybe_result = accessor->Get(array, array, new_length, elms_obj); } else { - maybe_result = array->GetPrototype()->GetElement(len - 1); + maybe_result = array->GetPrototype()->GetElement(isolate, len - 1); } if (maybe_result->IsFailure()) return maybe_result; MaybeObject* maybe_failure = diff --git a/src/execution.cc b/src/execution.cc index 6075624..048e6e0 100644 --- a/src/execution.cc +++ b/src/execution.cc @@ -708,7 +708,7 @@ Handle Execution::InstantiateFunction( int serial_number = Smi::cast(data->serial_number())->value(); Object* elm = isolate->native_context()->function_cache()-> - GetElementNoExceptionThrown(serial_number); + GetElementNoExceptionThrown(isolate, serial_number); if (elm->IsJSFunction()) return Handle(JSFunction::cast(elm)); // The function has not yet been instantiated in this context; do it. Handle args[] = { data }; diff --git a/src/factory.cc b/src/factory.cc index 819e9f0..7dde2a7 100644 --- a/src/factory.cc +++ b/src/factory.cc @@ -806,7 +806,7 @@ Handle Factory::EmergencyNewError(const char* message, *p++ = ' '; space--; if (space > 0) { - MaybeObject* maybe_arg = args->GetElement(i); + MaybeObject* maybe_arg = args->GetElement(isolate(), i); Handle arg_str(reinterpret_cast(maybe_arg)); const char* arg = *arg_str->ToCString(); Vector v2(p, static_cast(space)); @@ -1321,7 +1321,7 @@ Handle Factory::NewFunctionWithoutPrototype( Handle Factory::ToObject(Handle object) { - CALL_HEAP_FUNCTION(isolate(), object->ToObject(), Object); + CALL_HEAP_FUNCTION(isolate(), object->ToObject(isolate()), Object); } diff --git a/src/ic.cc b/src/ic.cc index 158d24a..190fdb1 100644 --- a/src/ic.cc +++ b/src/ic.cc @@ -566,7 +566,7 @@ MaybeObject* CallICBase::LoadFunction(State state, // the element if so. uint32_t index; if (name->AsArrayIndex(&index)) { - Handle result = Object::GetElement(object, index); + Handle result = Object::GetElement(isolate(), object, index); RETURN_IF_EMPTY_HANDLE(isolate(), result); if (result->IsJSFunction()) return *result; diff --git a/src/json-stringifier.h b/src/json-stringifier.h index 2de1401..c6ea288 100644 --- a/src/json-stringifier.h +++ b/src/json-stringifier.h @@ -602,12 +602,12 @@ BasicJsonStringifier::Result BasicJsonStringifier::SerializeJSArraySlow( Handle object, int length) { for (int i = 0; i < length; i++) { if (i > 0) Append(','); - Handle element = Object::GetElement(object, i); + Handle element = Object::GetElement(isolate_, object, i); RETURN_IF_EMPTY_HANDLE_VALUE(isolate_, element, EXCEPTION); if (element->IsUndefined()) { AppendAscii("null"); } else { - Result result = SerializeElement(object->GetIsolate(), element, i); + Result result = SerializeElement(isolate_, element, i); if (result == SUCCESS) continue; if (result == UNCHANGED) { AppendAscii("null"); @@ -678,9 +678,10 @@ BasicJsonStringifier::Result BasicJsonStringifier::SerializeJSObject( key_handle = factory_->NumberToString(Handle(key, isolate_)); uint32_t index; if (key->IsSmi()) { - property = Object::GetElement(object, Smi::cast(key)->value()); + property = Object::GetElement( + isolate_, object, Smi::cast(key)->value()); } else if (key_handle->AsArrayIndex(&index)) { - property = Object::GetElement(object, index); + property = Object::GetElement(isolate_, object, index); } else { property = GetProperty(isolate_, object, key_handle); } diff --git a/src/liveedit.cc b/src/liveedit.cc index b260c81..b6ac046 100644 --- a/src/liveedit.cc +++ b/src/liveedit.cc @@ -691,7 +691,7 @@ class JSArrayBasedStruct { Handle(Smi::FromInt(value), isolate())); } Object* GetField(int field_position) { - return array_->GetElementNoExceptionThrown(field_position); + return array_->GetElementNoExceptionThrown(isolate(), field_position); } int GetSmiValueField(int field_position) { Object* res = GetField(field_position); @@ -788,7 +788,8 @@ class SharedInfoWrapper : public JSArrayBasedStruct { public: static bool IsInstance(Handle array) { return array->length() == Smi::FromInt(kSize_) && - array->GetElementNoExceptionThrown(kSharedInfoOffset_)->IsJSValue(); + array->GetElementNoExceptionThrown( + array->GetIsolate(), kSharedInfoOffset_)->IsJSValue(); } explicit SharedInfoWrapper(Handle array) @@ -846,7 +847,8 @@ class FunctionInfoListener { HandleScope scope(isolate()); FunctionInfoWrapper info = FunctionInfoWrapper::cast( - result_->GetElementNoExceptionThrown(current_parent_index_)); + result_->GetElementNoExceptionThrown( + isolate(), current_parent_index_)); current_parent_index_ = info.GetParentIndex(); } @@ -855,7 +857,8 @@ class FunctionInfoListener { void FunctionCode(Handle function_code) { FunctionInfoWrapper info = FunctionInfoWrapper::cast( - result_->GetElementNoExceptionThrown(current_parent_index_)); + result_->GetElementNoExceptionThrown( + isolate(), current_parent_index_)); info.SetFunctionCode(function_code, Handle(isolate()->heap()->null_value(), isolate())); @@ -870,7 +873,8 @@ class FunctionInfoListener { } FunctionInfoWrapper info = FunctionInfoWrapper::cast( - result_->GetElementNoExceptionThrown(current_parent_index_)); + result_->GetElementNoExceptionThrown( + isolate(), current_parent_index_)); info.SetFunctionCode(Handle(shared->code()), Handle(shared->scope_info(), isolate())); info.SetSharedFunctionInfo(shared); @@ -1001,11 +1005,13 @@ JSArray* LiveEdit::GatherCompileInfo(Handle