From 3d8fe39ca7360b8fcb3558cf5625ad7525933256 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Tue, 21 Aug 2018 19:17:00 +0000 Subject: [PATCH] [InstCombine] Pull simple checks above a more complicated one. NFCI I'm assuming its easier to make sure the RHS of an XOR is all ones than it is to check for the many select patterns we have. So lets check that first. Same with the one use check. llvm-svn: 340321 --- llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp index a2dea10..e631e73 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp @@ -2919,12 +2919,10 @@ Instruction *InstCombiner::visitXor(BinaryOperator &I) { // %res = select i1 %cmp2, i32 %x, i32 %noty // // Same is applicable for smin/umax/umin. - { + if (match(Op1, m_AllOnes()) && Op0->hasOneUse()) { Value *LHS, *RHS; SelectPatternFlavor SPF = matchSelectPattern(Op0, LHS, RHS).Flavor; - if (Op0->hasOneUse() && SelectPatternResult::isMinOrMax(SPF) && - match(Op1, m_AllOnes())) { - + if (SelectPatternResult::isMinOrMax(SPF)) { Value *X; if (match(RHS, m_Not(m_Value(X)))) std::swap(RHS, LHS); -- 2.7.4