From 3d595ac5f5cbcf4db793caee035ab28304f41457 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Thu, 10 Nov 2022 12:19:30 +0100 Subject: [PATCH] cmd: remove superfluous if in eficonfig_edit_boot_option Goto for an immediately succeeding label is superfluous. Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option") Addresses-Coverity: 376202 ("Identical code for different branches") Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- cmd/eficonfig.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c index 2595dd9..0dc6e7b 100644 --- a/cmd/eficonfig.c +++ b/cmd/eficonfig.c @@ -1527,8 +1527,6 @@ static efi_status_t eficonfig_edit_boot_option(u16 *varname, struct eficonfig_bo } ret = eficonfig_set_boot_option(varname, final_dp, final_dp_size, bo->description, tmp); - if (ret != EFI_SUCCESS) - goto out; out: free(tmp); free(bo->optional_data); -- 2.7.4