From 3d3735e9f2e61097699d1cfcd324cefbcffca511 Mon Sep 17 00:00:00 2001 From: scygan Date: Thu, 25 Feb 2016 14:37:45 +0100 Subject: [PATCH] dEQP-VK.api.info.image_format_properties: enum value can be signed. The enum value 1<<31 is cast in test to VkDeviceSize, which is 64-bit unsigned int. According to C++ standard it is undefined wether enums are signed, or not, so the resulting value can be 0x8000000 or 0xffffffff80000000. At least this happens on MSVC++. --- external/vulkancts/modules/vulkan/api/vktApiFeatureInfo.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/external/vulkancts/modules/vulkan/api/vktApiFeatureInfo.cpp b/external/vulkancts/modules/vulkan/api/vktApiFeatureInfo.cpp index e2c5b38..7a38d67 100644 --- a/external/vulkancts/modules/vulkan/api/vktApiFeatureInfo.cpp +++ b/external/vulkancts/modules/vulkan/api/vktApiFeatureInfo.cpp @@ -67,10 +67,10 @@ enum { GUARD_SIZE = 0x20, //!< Number of bytes to check GUARD_VALUE = 0xcd, //!< Data pattern - - MINIMUM_REQUIRED_IMAGE_RESOURCE_SIZE = 1<<31, //!< Minimum value for VkImageFormatProperties::maxResourceSize (2GiB) }; +static const VkDeviceSize MINIMUM_REQUIRED_IMAGE_RESOURCE_SIZE = (1LLU<<31) //!< Minimum value for VkImageFormatProperties::maxResourceSize (2GiB) + enum LimitFormat { LIMIT_FORMAT_SIGNED_INT, -- 2.7.4