From 3d2bd4ff4975baac82885a258fa4ac21e90c7660 Mon Sep 17 00:00:00 2001 From: Michael Olbrich Date: Fri, 17 Jan 2014 07:46:09 +0100 Subject: [PATCH] v4l2bufferpool: don't ref the newly created allocator Otherwise the allocator will never be deleted. https://bugzilla.gnome.org/show_bug.cgi?id=712612 --- sys/v4l2/gstv4l2bufferpool.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/v4l2/gstv4l2bufferpool.c b/sys/v4l2/gstv4l2bufferpool.c index 90a94b2..2e44864 100644 --- a/sys/v4l2/gstv4l2bufferpool.c +++ b/sys/v4l2/gstv4l2bufferpool.c @@ -470,11 +470,13 @@ gst_v4l2_buffer_pool_set_config (GstBufferPool * bpool, GstStructure * config) if (obj->mode == GST_V4L2_IO_DMABUF) allocator = gst_dmabuf_allocator_new (); + else if (allocator) + gst_object_ref (allocator); if (pool->allocator) gst_object_unref (pool->allocator); - if ((pool->allocator = allocator)) - gst_object_ref (allocator); + pool->allocator = allocator; + pool->params = params; gst_buffer_pool_config_set_params (config, caps, size, min_buffers, -- 2.7.4