From 3cbe52c2e07ddb2c1f75e0ff9ff4e33a8e478877 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 27 May 2016 17:26:28 +0200 Subject: [PATCH] greybus: connection: log cport-enable error messages Log failures to disable a host cport, and include the connection name in cport enable/disable error messages. Reviewed-by: Viresh Kumar Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/connection.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c index 2da713ca..785b60b 100644 --- a/drivers/staging/greybus/connection.c +++ b/drivers/staging/greybus/connection.c @@ -278,7 +278,8 @@ static int gb_connection_hd_cport_enable(struct gb_connection *connection) ret = hd->driver->cport_enable(hd, connection->hd_cport_id); if (ret) { dev_err(&hd->dev, - "failed to enable host cport: %d\n", ret); + "%s: failed to enable host cport: %d\n", + connection->name, ret); return ret; } @@ -288,11 +289,17 @@ static int gb_connection_hd_cport_enable(struct gb_connection *connection) static void gb_connection_hd_cport_disable(struct gb_connection *connection) { struct gb_host_device *hd = connection->hd; + int ret; if (!hd->driver->cport_disable) return; - hd->driver->cport_disable(hd, connection->hd_cport_id); + ret = hd->driver->cport_disable(hd, connection->hd_cport_id); + if (ret) { + dev_err(&hd->dev, + "%s: failed to disable host cport: %d\n", + connection->name, ret); + } } static int -- 2.7.4