From 3c91d016349a5189691cf788da84608cae68bc13 Mon Sep 17 00:00:00 2001 From: Jorge Gorbe Moya Date: Mon, 17 Apr 2023 16:35:21 -0700 Subject: [PATCH] [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb. The functionality added by https://reviews.llvm.org/D145803 is gated by lldb tuning, so we need to build the test programs with `-glldb` to make these tests print the expected preferred name. Differential Revision: https://reviews.llvm.org/D148582 --- .../data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile | 4 +++- .../data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile index 7e57f13..c1c8b4a 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile @@ -2,5 +2,7 @@ CXX_SOURCES := main.cpp USE_LIBCPP := 1 -CXXFLAGS_EXTRAS := -std=c++14 +# We need debug info tuning for lldb in order to emit the preferred name for +# std::string. See https://reviews.llvm.org/D145803. +CXXFLAGS_EXTRAS := -std=c++14 -glldb include Makefile.rules diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile index 7e57f13..c1c8b4a 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile @@ -2,5 +2,7 @@ CXX_SOURCES := main.cpp USE_LIBCPP := 1 -CXXFLAGS_EXTRAS := -std=c++14 +# We need debug info tuning for lldb in order to emit the preferred name for +# std::string. See https://reviews.llvm.org/D145803. +CXXFLAGS_EXTRAS := -std=c++14 -glldb include Makefile.rules -- 2.7.4