From 3c8cee2f8ddaf82ac1a9e45a61fdb3203abadd87 Mon Sep 17 00:00:00 2001 From: "bmeurer@chromium.org" Date: Wed, 6 Nov 2013 06:59:32 +0000 Subject: [PATCH] Add isolate parameter to SetResourceConstraints, and deprecate version which depends on current isolate. BUG=None R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/38993005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17509 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- include/v8.h | 10 ++++++++-- src/api.cc | 7 +++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/include/v8.h b/include/v8.h index 44a74ed..5286baa 100644 --- a/include/v8.h +++ b/include/v8.h @@ -3788,10 +3788,16 @@ class V8_EXPORT ResourceConstraints { }; +V8_DEPRECATED( + "Use SetResourceConstraints(isolate, constraints) instead", + bool V8_EXPORT SetResourceConstraints(ResourceConstraints* constraints)); + + /** - * Sets the given ResourceConstraints on the current isolate. + * Sets the given ResourceConstraints on the given Isolate. */ -bool V8_EXPORT SetResourceConstraints(ResourceConstraints* constraints); +bool V8_EXPORT SetResourceConstraints(Isolate* isolate, + ResourceConstraints* constraints); // --- Exceptions --- diff --git a/src/api.cc b/src/api.cc index 8faf578..b90e693 100644 --- a/src/api.cc +++ b/src/api.cc @@ -568,7 +568,14 @@ ResourceConstraints::ResourceConstraints() bool SetResourceConstraints(ResourceConstraints* constraints) { i::Isolate* isolate = EnterIsolateIfNeeded(); + return SetResourceConstraints(reinterpret_cast(isolate), + constraints); +} + +bool SetResourceConstraints(Isolate* v8_isolate, + ResourceConstraints* constraints) { + i::Isolate* isolate = reinterpret_cast(v8_isolate); int young_space_size = constraints->max_young_space_size(); int old_gen_size = constraints->max_old_space_size(); int max_executable_size = constraints->max_executable_size(); -- 2.7.4