From 3c80118cf07261d8939f9afe4d1453891d977772 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 1 May 2019 23:48:48 +0200 Subject: [PATCH] Publish test artifacts to AzDO (dotnet/corefx#37296) * Publish test artifacts to AzDO * Disable two flaky UAP tests * Remove leftover buildconfiguration for netfx * Disable flaky printer test * Disable flaky PipeWriter test Commit migrated from https://github.com/dotnet/corefx/commit/75a54c95e2d31370bf8b5024a5b68b3e83cefb2e --- eng/pipelines/libraries/.azure-ci.yml | 15 ++++++++++++--- eng/pipelines/libraries/corefx-base.yml | 5 ----- eng/pipelines/libraries/helix.yml | 6 ------ eng/pipelines/libraries/windows.yml | 2 -- eng/sendtohelix.proj | 14 +------------- .../Microsoft.VisualBasic.Core/tests/Configurations.props | 1 - .../System.Diagnostics.Process/tests/ProcessTests.cs | 1 + .../tests/Printing/PrintDocumentTests.cs | 1 + .../System.IO.Pipelines/tests/PipeWriterTests.cs | 1 + .../tests/FunctionalTests/HttpClientHandlerTest.Http2.cs | 1 + .../tests/FunctionalTests/SocketOptionNameTest.cs | 2 ++ 11 files changed, 19 insertions(+), 30 deletions(-) diff --git a/eng/pipelines/libraries/.azure-ci.yml b/eng/pipelines/libraries/.azure-ci.yml index de5c4e8..4a4e9aa 100644 --- a/eng/pipelines/libraries/.azure-ci.yml +++ b/eng/pipelines/libraries/.azure-ci.yml @@ -8,11 +8,20 @@ trigger: include: - master - release/3.0 + paths: + exclude: + - Documentation/* + - /*.md -# TODO: add paths to exclude CI when modifying docs or stuff not affecting the build pr: -- master -- release/3.0 + branches: + include: + - master + - release/3.0 + paths: + exclude: + - Documentation/* + - /*.md resources: containers: diff --git a/eng/pipelines/libraries/corefx-base.yml b/eng/pipelines/libraries/corefx-base.yml index 4db5f43..9c23a1f 100644 --- a/eng/pipelines/libraries/corefx-base.yml +++ b/eng/pipelines/libraries/corefx-base.yml @@ -198,19 +198,14 @@ jobs: msbuildScript: $(_msbuildCommand) framework: $(_framework) outerloop: $(_outerloop) - enableAzurePipelinesReporter: false ${{ if eq(parameters.isOfficialBuild, 'true') }}: - isExternal: false - waitForCompletion: false officialBuildId: $(Build.BuildNumber) helixToken: $(HelixApiAccessToken) ${{ if eq(parameters.isOfficialBuild, 'false') }}: # TODO: SET Creator to the PR owner whenever Azure DevOps supports a good way to retrieve it. creator: dotnet-bot - isExternal: true - waitForCompletion: true helixToken: '' - ${{ if eq(parameters.isOfficialBuild, 'true') }}: diff --git a/eng/pipelines/libraries/helix.yml b/eng/pipelines/libraries/helix.yml index cf1bf9d..68073f8 100644 --- a/eng/pipelines/libraries/helix.yml +++ b/eng/pipelines/libraries/helix.yml @@ -5,12 +5,9 @@ parameters: framework: '' helixQueues: '' helixToken: '' - isExternal: '' # true | false msbuildScript: '' targetOS: '' - waitForCompletion: '' # true | false officialBuildId: '' - enableAzurePipelinesReporter: '' # true | false outerloop: '' # true | false condition: always() @@ -26,11 +23,8 @@ steps: /p:HelixTargetQueues=${{ parameters.helixQueues }} /p:HelixBuild=$(Build.BuildNumber) /p:HelixAccessToken=${{ parameters.helixToken }} - /p:WaitForWorkItemCompletion=${{ parameters.waitForCompletion }} - /p:IsExternal=${{ parameters.isExternal }} /p:Creator=${{ parameters.creator }} /p:OfficialBuildId=${{ parameters.officialBuildId }} - /p:EnableAzurePipelinesReporter=${{ parameters.enableAzurePipelinesReporter }} /bl:$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/SendToHelix.binlog displayName: Send to Helix condition: and(succeeded(), ${{ parameters.condition }}) diff --git a/eng/pipelines/libraries/windows.yml b/eng/pipelines/libraries/windows.yml index 09610ea..c6bca6c 100644 --- a/eng/pipelines/libraries/windows.yml +++ b/eng/pipelines/libraries/windows.yml @@ -167,8 +167,6 @@ jobs: submitToHelix: true buildExtraArguments: /p:RuntimeOS=win10 - # azure pipelines reporter only supports xunit results based tests. - enableAzurePipelinesReporter: false variables: - _outerloop: false diff --git a/eng/sendtohelix.proj b/eng/sendtohelix.proj index 32e88f1..5b07f7f 100644 --- a/eng/sendtohelix.proj +++ b/eng/sendtohelix.proj @@ -32,19 +32,7 @@ $(BuildConfiguration)- PackageTests-$(ConfigurationGroup)-$(ArchGroup) - 4 - - - - - true - false - - - - - true - false + $(WaitForWorkItemCompletion) diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props b/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props index 0ea07aa..acf56fa 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props @@ -3,7 +3,6 @@ netcoreapp; uap; - netfx; \ No newline at end of file diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs index 191830b..2f19b91 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs @@ -1471,6 +1471,7 @@ namespace System.Diagnostics.Tests } } + [ActiveIssue(37325)] [Fact] [PlatformSpecific(TestPlatforms.Linux | TestPlatforms.Windows)] // Expected process HandleCounts differs on OSX [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Handle count change is not reliable, but seems less robust on NETFX")] diff --git a/src/libraries/System.Drawing.Common/tests/Printing/PrintDocumentTests.cs b/src/libraries/System.Drawing.Common/tests/Printing/PrintDocumentTests.cs index ec53164..ab6a7c3 100644 --- a/src/libraries/System.Drawing.Common/tests/Printing/PrintDocumentTests.cs +++ b/src/libraries/System.Drawing.Common/tests/Printing/PrintDocumentTests.cs @@ -169,6 +169,7 @@ namespace System.Drawing.Printing.Tests } [ActiveIssue(20884, TestPlatforms.AnyUnix)] + [ActiveIssue(30223)] [ConditionalFact(Helpers.AnyInstalledPrinters, Helpers.IsDrawingSupported)] public void EndPrint_SetValue_ReturnsExpected() { diff --git a/src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs b/src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs index 0ae5110..68ad54f 100644 --- a/src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs +++ b/src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs @@ -233,6 +233,7 @@ namespace System.IO.Pipelines.Tests pipe.Reader.Complete(); } + [ActiveIssue(37239)] [Fact] public async Task CompleteWithLargeWriteThrows() { diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs index 176b409..bb5fc03 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs @@ -194,6 +194,7 @@ namespace System.Net.Http.Functional.Tests } } + [ActiveIssue(35466)] [ConditionalTheory(nameof(SupportsAlpn))] [InlineData(SettingId.MaxFrameSize, 16383, ProtocolErrors.PROTOCOL_ERROR, true)] [InlineData(SettingId.MaxFrameSize, 162777216, ProtocolErrors.PROTOCOL_ERROR, true)] diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs index daaa2c1..09fb600 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs @@ -65,6 +65,7 @@ namespace System.Net.Sockets.Tests } } + [ActiveIssue(31609, TargetFrameworkMonikers.Uap)] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] // Skip on Nano: dotnet/corefx #29929 public async Task MulticastInterface_Set_AnyInterface_Succeeds() { @@ -129,6 +130,7 @@ namespace System.Net.Sockets.Tests } } + [ActiveIssue(31609, TargetFrameworkMonikers.Uap)] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] // Skip on Nano: dotnet/corefx #29929 [PlatformSpecific(~TestPlatforms.OSX)] public async Task MulticastInterface_Set_IPv6_AnyInterface_Succeeds() -- 2.7.4