From 3c576de30bb49a4821923928f85f13e957d1e47d Mon Sep 17 00:00:00 2001 From: Jakub Kicinski Date: Tue, 4 Sep 2018 07:37:31 -0700 Subject: [PATCH] nfp: fix readq on absolute RTsyms Return the error and report value through the output param. Fixes: 640917dd81b6 ("nfp: support access to absolute RTsyms") Reported-by: Dan Carpenter Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron Signed-off-by: David S. Miller --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c index 108ce8c..4003ed7 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c @@ -337,8 +337,10 @@ int __nfp_rtsym_readq(struct nfp_cpp *cpp, const struct nfp_rtsym *sym, u64 addr; int err; - if (sym->type == NFP_RTSYM_TYPE_ABS) - return sym->addr; + if (sym->type == NFP_RTSYM_TYPE_ABS) { + *value = sym->addr; + return 0; + } err = nfp_rtsym_to_dest(cpp, sym, action, token, off, &cpp_id, &addr); if (err) -- 2.7.4