From 3be8651fccba6479908df22a32a2adff2c49a1f4 Mon Sep 17 00:00:00 2001 From: bmeurer Date: Mon, 1 Jun 2015 03:58:51 -0700 Subject: [PATCH] Revert of Re-enable on-heap typed array allocation (patchset #1 id:1 of https://codereview.chromium.org/1166433004/) Reason for revert: Win32 breakage Original issue's description: > Re-enable on-heap typed array allocation > > BUG=v8:3996 > R=mstarzinger@chromium.org > LOG=y > > Committed: https://crrev.com/f91df1f25dec4f1982c40af6118da8b699777475 > Cr-Commit-Position: refs/heads/master@{#28722} TBR=mstarzinger@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1158193004 Cr-Commit-Position: refs/heads/master@{#28723} --- src/hydrogen.cc | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/hydrogen.cc b/src/hydrogen.cc index 809640f..30406d6 100644 --- a/src/hydrogen.cc +++ b/src/hydrogen.cc @@ -9727,18 +9727,8 @@ HValue* HGraphBuilder::BuildAllocateEmptyArrayBuffer(HValue* byte_length) { native_context, nullptr, HObjectAccess::ForContextSlot(Context::ARRAY_BUFFER_MAP_INDEX))); - HConstant* empty_fixed_array = - Add(isolate()->factory()->empty_fixed_array()); - Add( - result, HObjectAccess::ForJSArrayOffset(JSArray::kPropertiesOffset), - empty_fixed_array); - Add( - result, HObjectAccess::ForJSArrayOffset(JSArray::kElementsOffset), - empty_fixed_array); - Add( - result, HObjectAccess::ForJSArrayBufferBackingStore().WithRepresentation( - Representation::Smi()), - graph()->GetConstant0()); + Add(result, HObjectAccess::ForJSArrayBufferBackingStore(), + Add(ExternalReference())); Add(result, HObjectAccess::ForJSArrayBufferByteLength(), byte_length); Add(result, HObjectAccess::ForJSArrayBufferBitFieldSlot(), @@ -9945,7 +9935,7 @@ void HOptimizedGraphBuilder::GenerateTypedArrayInitialize( CHECK_ALIVE(VisitForValue(arguments->at(kObjectArg))); HValue* obj = Pop(); - if (!arguments->at(kArrayIdArg)->IsLiteral()) { + if (arguments->at(kArrayIdArg)->IsLiteral()) { // This should never happen in real use, but can happen when fuzzing. // Just bail out. Bailout(kNeedSmiLiteral); -- 2.7.4