From 3b9aea04d23bb9e7d058953e075c38525e9baa11 Mon Sep 17 00:00:00 2001 From: Steve Hay Date: Wed, 19 Sep 2012 17:39:17 +0100 Subject: [PATCH] Add new warning about sleep's limitation on Windows This also came up recently in [perl #33096]. On Windows, sleep's unsigned int argument range is effectively reduced by a factor of 1000 because the emulation uses milliseconds rather than seconds. --- pod/perldiag.pod | 6 ++++++ win32/win32.c | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/pod/perldiag.pod b/pod/perldiag.pod index e579b11..fee1506 100644 --- a/pod/perldiag.pod +++ b/pod/perldiag.pod @@ -4499,6 +4499,12 @@ Perhaps you put it into the wrong package? internal bookkeeping of op trees. An op tree needed to be freed after a compilation error, but could not be found, so it was leaked instead. +=item sleep(%u) too large + +(W overflow) You called C with a number that was larger than +it can reliably handle and C probably slept for less time than +requested. + =item Smart matching a non-overloaded object breaks encapsulation (F) You should not use the C<~~> operator on an object that does not diff --git a/win32/win32.c b/win32/win32.c index a16410f..8bb1369 100644 --- a/win32/win32.c +++ b/win32/win32.c @@ -2426,7 +2426,11 @@ win32_sleep(unsigned int t) { dTHX; /* Win32 times are in ms so *1000 in and /1000 out */ - return win32_msgwait(aTHX_ 0, NULL, t*1000, NULL)/1000; + if (t > UINT_MAX / 1000) { + Perl_ck_warner(aTHX_ packWARN(WARN_OVERFLOW), + "sleep(%lu) too large", t); + } + return win32_msgwait(aTHX_ 0, NULL, t * 1000, NULL) / 1000; } DllExport unsigned int -- 2.7.4