From 3b942349f3d4b553c43ba0ed6335282aa2fb61fc Mon Sep 17 00:00:00 2001 From: Jooseok Song Date: Fri, 1 Sep 2017 14:02:57 +0900 Subject: [PATCH] Fix dispose and wrong statement in comment Change-Id: Icc78198e2cd841c137e9cfbf6adbe2ebdc726086 --- .../Tizen.Account.AccountManager/Account.cs | 14 +++++++------- .../Tizen.Account.AccountManager/AccountEnums.cs | 2 +- .../Tizen.Account.AccountManager/AccountErrorFactory.cs | 4 ++-- .../Tizen.Account.AccountManager/AccountProvider.cs | 4 ++-- .../Tizen.Account.AccountManager/AccountService.cs | 7 ++++--- 5 files changed, 16 insertions(+), 15 deletions(-) diff --git a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/Account.cs b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/Account.cs index 498bb84..2a09e98 100644 --- a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/Account.cs +++ b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/Account.cs @@ -27,6 +27,11 @@ namespace Tizen.Account.AccountManager { private readonly SafeAccountHandle _handle; + /// + /// Account constructor. + /// + /// 4 + /// The account handle. public Account(SafeAccountHandle handle) { _handle = handle; @@ -607,16 +612,11 @@ namespace Tizen.Account.AccountManager GC.SuppressFinalize(this); } - private void Dispose(bool disposing) + protected virtual void Dispose(bool disposing) { if (!disposing) { - //if (_handle != IntPtr.Zero) - //{ - // _handle = IntPtr.Zero; - //} - //_handle.Dispose(); - GC.SuppressFinalize(this); + _handle.Dispose(); } } } diff --git a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountEnums.cs b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountEnums.cs index 68a7a65..53942e0 100644 --- a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountEnums.cs +++ b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountEnums.cs @@ -96,7 +96,7 @@ namespace Tizen.Account.AccountManager Idle, /// - /// Acount sync supported and sync status is running. + /// Account sync supported and sync status is running. /// /// 3 Running diff --git a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountErrorFactory.cs b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountErrorFactory.cs index 51c31dd..f23c792 100644 --- a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountErrorFactory.cs +++ b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountErrorFactory.cs @@ -20,7 +20,7 @@ using Tizen; namespace Tizen.Account.AccountManager { /// - /// Enumeration for the types of error occured, if any. + /// Enumeration for the types of error occurred, if any. /// /// 3 public enum AccountError @@ -45,7 +45,7 @@ namespace Tizen.Account.AccountManager /// Same user name exists in your application. /// /// 3 - Duplcated = -0x01000000 | 0x01, + Duplicated = -0x01000000 | 0x01, /// /// Empty data. /// diff --git a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountProvider.cs b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountProvider.cs index ce34491..be9e077 100644 --- a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountProvider.cs +++ b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountProvider.cs @@ -69,7 +69,7 @@ namespace Tizen.Account.AccountManager } /// - /// Serviceprovider ID of the account provider. + /// ServiceProvider ID of the account provider. /// /// 3 public string ServiceProviderId @@ -365,7 +365,7 @@ namespace Tizen.Account.AccountManager GC.SuppressFinalize(this); } - private void Dispose(bool disposing) + protected virtual void Dispose(bool disposing) { if (!disposing) { diff --git a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountService.cs b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountService.cs index d335a8e..8ebab51 100644 --- a/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountService.cs +++ b/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountService.cs @@ -200,7 +200,7 @@ namespace Tizen.Account.AccountManager /// The AccountProvider instance associated with the given application ID. /// http://tizen.org/privilege/account.read /// http://tizen.org/feature/account - /// In case of any DB error or record not found for given appid. + /// In case of any DB error or record not found for given appId. /// In case of an invalid parameter. /// In case of privilege not defined. /// The required feature is not supported. @@ -262,6 +262,7 @@ namespace Tizen.Account.AccountManager /// /// 3 /// New Account instance to be added. + /// The account ID of the account instance. /// http://tizen.org/privilege/account.read /// http://tizen.org/privilege/account.write /// http://tizen.org/feature/account @@ -590,9 +591,9 @@ namespace Tizen.Account.AccountManager /// /// 3 /// - /// ContentUpdate event is triggered if the MediaInformaion updated/deleted or new information is inserted. + /// ContentUpdate event is triggered if the MediaInformation updated/deleted or new information is inserted. /// - /// + /// An object that contains information about sender /// A ContentUpdatedEventArgs object that contains information about the update operation. /// http://tizen.org/privilege/account.read /// http://tizen.org/feature/account -- 2.7.4