From 3b07be06a459f655b8cfa3e9d87bd534be5247d4 Mon Sep 17 00:00:00 2001
From: Evan Shelhamer <shelhamer@imaginarynumber.net>
Date: Thu, 7 Aug 2014 11:56:45 -0700
Subject: [PATCH] consolidate gpu and device_id args in caffe tool

---
 examples/imagenet/time_imagenet.sh | 17 ++++++-----------
 tools/caffe.cpp                    | 23 +++++++++++------------
 2 files changed, 17 insertions(+), 23 deletions(-)

diff --git a/examples/imagenet/time_imagenet.sh b/examples/imagenet/time_imagenet.sh
index c83b0c0..c448b49 100755
--- a/examples/imagenet/time_imagenet.sh
+++ b/examples/imagenet/time_imagenet.sh
@@ -3,20 +3,15 @@
 TOOLS=../../build/tools
 
 if [ -z "$1" ]; then
-  echo "Using CPU! To run GPU speedtest, use:"
-  echo "    ./speedtest_imagenet.sh <device ID>"
-  echo "(Try ./speedtest_imagenet.sh 0 if you have just one GPU.)"
+  echo "Using CPU! To time GPU mode, use:"
+  echo "    ./time_imagenet.sh <device ID>"
+  echo "(Try ./time_imagenet.sh 0 if you have just one GPU.)"
   sleep 3  # Let the user read
-  WITH_GPU=false
-  DEVICE_ID=0
+  GPU=""
 else
-  WITH_GPU=true
-  DEVICE_ID=$1
+  GPU="--gpu=$1"
 fi
 
-$TOOLS/caffe time \
-  --model=imagenet_train_val.prototxt \
-  --gpu=${WITH_GPU} \
-  --device_id=${DEVICE_ID}
+$TOOLS/caffe time --model=imagenet_train_val.prototxt ${GPU}
 
 echo "Done."
diff --git a/tools/caffe.cpp b/tools/caffe.cpp
index 313803d..22d9eb1 100644
--- a/tools/caffe.cpp
+++ b/tools/caffe.cpp
@@ -17,10 +17,8 @@ using caffe::Timer;
 using caffe::vector;
 
 
-DEFINE_int32(device_id, 0,
-    "The GPU device ID to use.");
-DEFINE_bool(gpu, false,
-    "Run in GPU mode when true.");
+DEFINE_int32(gpu, -1,
+    "Run in GPU mode on given device ID.");
 DEFINE_string(solver, "",
     "The solver definition protocol buffer text file.");
 DEFINE_string(model, "",
@@ -71,8 +69,9 @@ static BrewFunction GetBrewFunction(const caffe::string& name) {
 
 // Device Query: show diagnostic information for a GPU device.
 int device_query() {
-  LOG(INFO) << "Querying device_id = " << FLAGS_device_id;
-  caffe::Caffe::SetDevice(FLAGS_device_id);
+  CHECK_GT(FLAGS_gpu, -1) << "Need a device ID to query.";
+  LOG(INFO) << "Querying device ID = " << FLAGS_gpu;
+  caffe::Caffe::SetDevice(FLAGS_gpu);
   caffe::Caffe::DeviceQuery();
   return 0;
 }
@@ -113,9 +112,9 @@ int test() {
   CHECK_GT(FLAGS_weights.size(), 0) << "Need model weights to score.";
 
   // Set device id and mode
-  if (FLAGS_gpu) {
-    LOG(INFO) << "Use GPU with device id " << FLAGS_device_id;
-    Caffe::SetDevice(FLAGS_device_id);
+  if (FLAGS_gpu >= 0) {
+    LOG(INFO) << "Use GPU with device ID " << FLAGS_gpu;
+    Caffe::SetDevice(FLAGS_gpu);
     Caffe::set_mode(Caffe::GPU);
   } else {
     LOG(INFO) << "Use CPU.";
@@ -146,9 +145,9 @@ int time() {
   CHECK_GT(FLAGS_model.size(), 0) << "Need a model definition to time.";
 
   // Set device id and mode
-  if (FLAGS_gpu) {
-    LOG(INFO) << "Use GPU with device id " << FLAGS_device_id;
-    Caffe::SetDevice(FLAGS_device_id);
+  if (FLAGS_gpu >= 0) {
+    LOG(INFO) << "Use GPU with device ID " << FLAGS_gpu;
+    Caffe::SetDevice(FLAGS_gpu);
     Caffe::set_mode(Caffe::GPU);
   } else {
     LOG(INFO) << "Use CPU.";
-- 
2.7.4