From 3abad7af66f7eab2caeb3bf2a129721e375e29d0 Mon Sep 17 00:00:00 2001 From: Stefan Sauer Date: Tue, 18 Feb 2014 11:28:18 +0100 Subject: [PATCH] pulsesink: fix crash when getting the current-device in NULL->READY The "goto unlock" is wrong as in this code path we haven't take the lock yet. Fixes #724619 --- ext/pulse/pulsesink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c index 0c8ed4d..ec7d4ef 100644 --- a/ext/pulse/pulsesink.c +++ b/ext/pulse/pulsesink.c @@ -2788,7 +2788,7 @@ no_mainloop: no_buffer: { GST_DEBUG_OBJECT (pulsesink, "we have no ringbuffer"); - goto unlock; + return NULL; } info_failed: { -- 2.7.4