From 3a7c7719e89552f26560fcdd03bdb5f5c94ae533 Mon Sep 17 00:00:00 2001 From: Sean Young Date: Tue, 4 Dec 2018 04:59:10 -0500 Subject: [PATCH] media: dib7000p: Remove dead code Clang warns that 'interleaving' is assigned to itself in this function. drivers/media/dvb-frontends/dib7000p.c:1874:15: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] interleaving = interleaving; ~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ 1 warning generated. Just remove the self-assign and leave existing code in place for now. Reported-by: Nick Desaulniers Suggested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Reviewed-by: Nick Desaulniers Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab [sw0312.kim: cherry-pick mainline commit d95947c05eaf to remove llvm/clang build warning] Signed-off-by: Seung-Woo Kim Change-Id: I3e34832e3b095fdedbf1ee7557be66370726bf85 --- drivers/media/dvb-frontends/dib7000p.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/dib7000p.c b/drivers/media/dvb-frontends/dib7000p.c index 5838786..2818e8d 100644 --- a/drivers/media/dvb-frontends/dib7000p.c +++ b/drivers/media/dvb-frontends/dib7000p.c @@ -1871,10 +1871,13 @@ static u32 dib7000p_get_time_us(struct dvb_frontend *demod) break; } - interleaving = interleaving; - denom = bits_per_symbol * rate_num * fft_div * 384; + /* + * FIXME: check if the math makes sense. If so, fill the + * interleaving var. + */ + /* If calculus gets wrong, wait for 1s for the next stats */ if (!denom) return 0; -- 2.7.4