From 3a61a4d10452a992e712be2646b7ecb003a86ddf Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Fri, 25 Mar 2016 20:30:10 +0000 Subject: [PATCH] Remove useless and unused CrashRecoveryContext::getBacktrace(). This function always returned an empty string. llvm-svn: 264458 --- llvm/include/llvm/Support/CrashRecoveryContext.h | 10 +--------- llvm/lib/Support/CrashRecoveryContext.cpp | 8 -------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/llvm/include/llvm/Support/CrashRecoveryContext.h b/llvm/include/llvm/Support/CrashRecoveryContext.h index 1a1c743..485ae5f 100644 --- a/llvm/include/llvm/Support/CrashRecoveryContext.h +++ b/llvm/include/llvm/Support/CrashRecoveryContext.h @@ -70,8 +70,7 @@ public: /// \return True if the function completed successfully, and false if the /// function crashed (or HandleCrash was called explicitly). Clients should /// make as little assumptions as possible about the program state when - /// RunSafely has returned false. Clients can use getBacktrace() to retrieve - /// the backtrace of the crash on failures. + /// RunSafely has returned false. bool RunSafely(function_ref Fn); bool RunSafely(void (*Fn)(void*), void *UserData) { return RunSafely([&]() { Fn(UserData); }); @@ -94,13 +93,6 @@ public: /// \brief Explicitly trigger a crash recovery in the current process, and /// return failure from RunSafely(). This function does not return. void HandleCrash(); - - /// \brief Return a string containing the backtrace where the crash was - /// detected; or empty if the backtrace wasn't recovered. - /// - /// This function is only valid when a crash has been detected (i.e., - /// RunSafely() has returned false. - const std::string &getBacktrace() const; }; class CrashRecoveryContextCleanup { diff --git a/llvm/lib/Support/CrashRecoveryContext.cpp b/llvm/lib/Support/CrashRecoveryContext.cpp index 3f4ef9d..98865f5 100644 --- a/llvm/lib/Support/CrashRecoveryContext.cpp +++ b/llvm/lib/Support/CrashRecoveryContext.cpp @@ -31,7 +31,6 @@ struct CrashRecoveryContextImpl { const CrashRecoveryContextImpl *Next; CrashRecoveryContext *CRC; - std::string Backtrace; ::jmp_buf JumpBuffer; volatile unsigned Failed : 1; unsigned SwitchedThread : 1; @@ -335,13 +334,6 @@ void CrashRecoveryContext::HandleCrash() { CRCI->HandleCrash(); } -const std::string &CrashRecoveryContext::getBacktrace() const { - CrashRecoveryContextImpl *CRC = (CrashRecoveryContextImpl *) Impl; - assert(CRC && "Crash recovery context never initialized!"); - assert(CRC->Failed && "No crash was detected!"); - return CRC->Backtrace; -} - // FIXME: Portability. static void setThreadBackgroundPriority() { #ifdef __APPLE__ -- 2.7.4