From 3a204ea97eaf5946415baf60f418032f2d822f6f Mon Sep 17 00:00:00 2001
From: mstarzinger <mstarzinger@chromium.org>
Date: Mon, 7 Sep 2015 07:24:05 -0700
Subject: [PATCH] [presubmit] Enable build/c++11 linter checking.

This enables the general linter checking for "build/c++11" violations
during presubmit and instead marks the few known exceptions that we
allow explicitly.

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1317463007

Cr-Commit-Position: refs/heads/master@{#30621}
---
 include/v8.h       | 6 +++---
 src/codegen.cc     | 2 +-
 tools/presubmit.py | 1 -
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/include/v8.h b/include/v8.h
index ab5056d..54c6dcd 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -815,7 +815,7 @@ class Global : public PersistentBase<T> {
   /**
    * Move constructor.
    */
-  V8_INLINE Global(Global&& other) : PersistentBase<T>(other.val_) {
+  V8_INLINE Global(Global&& other) : PersistentBase<T>(other.val_) {  // NOLINT
     other.val_ = nullptr;
   }
   V8_INLINE ~Global() { this->Reset(); }
@@ -823,7 +823,7 @@ class Global : public PersistentBase<T> {
    * Move via assignment.
    */
   template <class S>
-  V8_INLINE Global& operator=(Global<S>&& rhs) {
+  V8_INLINE Global& operator=(Global<S>&& rhs) {  // NOLINT
     TYPE_CHECK(T, S);
     if (this != &rhs) {
       this->Reset();
@@ -835,7 +835,7 @@ class Global : public PersistentBase<T> {
   /**
    * Pass allows returning uniques from functions, etc.
    */
-  Global Pass() { return static_cast<Global&&>(*this); }
+  Global Pass() { return static_cast<Global&&>(*this); }  // NOLINT
 
   /*
    * For compatibility with Chromium's base::Bind (base::Passed).
diff --git a/src/codegen.cc b/src/codegen.cc
index 0b130e9..4791fe0 100644
--- a/src/codegen.cc
+++ b/src/codegen.cc
@@ -5,7 +5,7 @@
 #include "src/codegen.h"
 
 #if defined(V8_OS_AIX)
-#include <fenv.h>
+#include <fenv.h>  // NOLINT(build/c++11)
 #endif
 #include "src/bootstrapper.h"
 #include "src/compiler.h"
diff --git a/tools/presubmit.py b/tools/presubmit.py
index 58c130e..c11e89d 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -53,7 +53,6 @@ from subprocess import PIPE
 # TODO(mstarzinger): Fix and re-enable readability/namespace
 
 LINT_RULES = """
--build/c++11
 -build/header_guard
 +build/include_alpha
 -build/include_what_you_use
-- 
2.7.4