From 39f39f8da036b46eed7c489ac932c81b17cf834c Mon Sep 17 00:00:00 2001 From: Hosang Kim Date: Fri, 24 Jul 2015 14:30:21 +0900 Subject: [PATCH] elm_gengrid: Fix condition error. Summary: I missed "!" in if condition and missed it->unhighlighted_cb(). @fix Reviewers: singh.amitesh, raster, cedric, SanghyeonLee Reviewed By: SanghyeonLee Differential Revision: https://phab.enlightenment.org/D2861 --- src/lib/elm_gengrid.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c index ce6d624..320375b 100644 --- a/src/lib/elm_gengrid.c +++ b/src/lib/elm_gengrid.c @@ -578,11 +578,14 @@ _item_mouse_move_cb(void *data, } } else if (ELM_RECTS_POINT_OUT(x, y, w, h, ev->cur.canvas.x, ev->cur.canvas.y) && - !sd->reorder_it ) + !sd->reorder_it ) { - ELM_SAFE_FREE(it->long_timer, ecore_timer_del); - if (!sd->was_selected) - it->unsel_cb(it); + ELM_SAFE_FREE(it->long_timer, ecore_timer_del); + if (!sd->was_selected) + { + it->unhighlight_cb(it); + it->unsel_cb(it); + } it->base->still_in = EINA_FALSE; } @@ -1105,7 +1108,7 @@ _item_mouse_up_cb(void *data, if (eo_do_ret(eo_it, tmp, elm_wdg_item_disabled_get())) return; - if (sd->on_hold || it->base->still_in) + if (sd->on_hold || !it->base->still_in) { sd->longpressed = EINA_FALSE; sd->on_hold = EINA_FALSE; -- 2.7.4