From 39ba33b8f02fb91f21620279fe4df735fb59fc0e Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper@gmail.com>
Date: Wed, 29 Apr 2015 07:13:12 +0000
Subject: [PATCH] [TableGen] Fold a couple dyn_casts into the ifs that check
 their results. NFC

llvm-svn: 236088
---
 llvm/lib/TableGen/Record.cpp | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/llvm/lib/TableGen/Record.cpp b/llvm/lib/TableGen/Record.cpp
index b58a004..b8fc94d 100644
--- a/llvm/lib/TableGen/Record.cpp
+++ b/llvm/lib/TableGen/Record.cpp
@@ -1007,21 +1007,18 @@ static Init *ForeachHelper(Init *LHS, Init *MHS, Init *RHS, RecTy *Type,
 static Init *EvaluateOperation(OpInit *RHSo, Init *LHS, Init *Arg,
                                RecTy *Type, Record *CurRec,
                                MultiClass *CurMultiClass) {
-  std::vector<Init *> NewOperands;
-
-  TypedInit *TArg = dyn_cast<TypedInit>(Arg);
-
   // If this is a dag, recurse
-  if (TArg && TArg->getType()->getAsString() == "dag") {
-    Init *Result = ForeachHelper(LHS, Arg, RHSo, Type,
-                                 CurRec, CurMultiClass);
-    return Result;
+  if (TypedInit *TArg = dyn_cast<TypedInit>(Arg)) {
+    if (TArg->getType()->getAsString() == "dag") {
+      Init *Result = ForeachHelper(LHS, Arg, RHSo, Type,
+                                   CurRec, CurMultiClass);
+      return Result;
+    }
   }
 
+  std::vector<Init *> NewOperands;
   for (int i = 0; i < RHSo->getNumOperands(); ++i) {
-    OpInit *RHSoo = dyn_cast<OpInit>(RHSo->getOperand(i));
-
-    if (RHSoo) {
+    if (OpInit *RHSoo = dyn_cast<OpInit>(RHSo->getOperand(i))) {
       Init *Result = EvaluateOperation(RHSoo, LHS, Arg,
                                        Type, CurRec, CurMultiClass);
       if (Result) {
-- 
2.7.4