From 39b657ea2a3871f23def9ed8762237236010b124 Mon Sep 17 00:00:00 2001 From: Hyung-Kyu Choi Date: Wed, 31 May 2017 14:56:25 +0900 Subject: [PATCH] [RyuJIT/ARM32] Applying review feedback - Group cases for each target to improve readability Signed-off-by: Hyung-Kyu Choi Commit migrated from https://github.com/dotnet/coreclr/commit/a94654c90f0b2c203a10063a3248f18d12373411 --- src/coreclr/src/jit/lowerarmarch.cpp | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/coreclr/src/jit/lowerarmarch.cpp b/src/coreclr/src/jit/lowerarmarch.cpp index a6e2f5f..daaedc4 100644 --- a/src/coreclr/src/jit/lowerarmarch.cpp +++ b/src/coreclr/src/jit/lowerarmarch.cpp @@ -111,25 +111,34 @@ bool Lowering::IsContainableImmed(GenTree* parentNode, GenTree* childNode) #endif break; +#ifdef _TARGET_ARM64_ case GT_EQ: case GT_NE: case GT_LT: case GT_LE: case GT_GE: case GT_GT: -#ifdef _TARGET_ARM64_ return emitter::emitIns_valid_imm_for_cmp(immVal, size); break; -#endif case GT_AND: case GT_OR: case GT_XOR: -#ifdef _TARGET_ARM64_ return emitter::emitIns_valid_imm_for_alu(immVal, size); + break; #elif defined(_TARGET_ARM_) + case GT_EQ: + case GT_NE: + case GT_LT: + case GT_LE: + case GT_GE: + case GT_GT: + case GT_AND: + case GT_OR: + case GT_XOR: return emitter::emitIns_valid_imm_for_alu(immVal); -#endif break; +#endif // _TARGET_ARM_ + #ifdef _TARGET_ARM64_ case GT_STORE_LCL_VAR: if (immVal == 0) -- 2.7.4