From 397afe5ba1e9abeb48b801c864a56bda415441ce Mon Sep 17 00:00:00 2001 From: Jessica Clarke Date: Sun, 11 Jul 2021 03:28:20 +0100 Subject: [PATCH] fw_base: Put data in .data rather than .text The -N linker option is supposed to make .text writable, but GNU ld and LLD differ in interpreting what that means. GNU ld will happily let you have relocations in it, but LLD will see that the input section is read-only (even though the output section is writable) and give an error. It's unclear if either of them intend to have that behaviour in this edge case, but regardless there's no reason not to just put the data in a writable .data section. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel --- firmware/fw_base.S | 1 + 1 file changed, 1 insertion(+) diff --git a/firmware/fw_base.S b/firmware/fw_base.S index a1213e3..928ca91 100644 --- a/firmware/fw_base.S +++ b/firmware/fw_base.S @@ -506,6 +506,7 @@ _skip_trap_exit_rv32_hyp: /* We don't expect to reach here hence just hang */ j _start_hang + .data .align 3 #ifdef FW_PIC _runtime_offset: -- 2.7.4