From 3977477d48bc85a5719f3d54040b257cc7e85709 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Tue, 16 Mar 2021 15:56:50 +0100 Subject: [PATCH] glibcymbols.read_abilist: Add check for duplicate symbols This detects some bogus abilist files. Reviewed-by: Adhemerval Zanella --- scripts/glibcsymbols.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/glibcsymbols.py b/scripts/glibcsymbols.py index e329ead..1bdd19e 100644 --- a/scripts/glibcsymbols.py +++ b/scripts/glibcsymbols.py @@ -63,7 +63,10 @@ def read_abilist(path): with open(path) as inp: for line in inp: version, symbol, flags = line.strip().split(' ', 2) - result[VersionedSymbol(symbol, version)] = flags + versym = VersionedSymbol(symbol, version) + if versym in result: + raise IOError("{}: duplicate symbol {}".format(path, versym)) + result[versym] = flags return result def abilist_lines(symbols): -- 2.7.4