From 396fbe264f5a43a57241043f66c1df3c526bc1ca Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2@gmail.com>
Date: Thu, 24 Nov 2022 15:18:26 -0500
Subject: [PATCH] [libc++] Bump AppleClang compiler requirement

Per our policy, the latest released AppleClang has been 14 for a while,
so libc++ is removing support for AppleClang 13. Our CI bots have been
moved to AppleClang 14 a few weeks ago.

Differential Revision: https://reviews.llvm.org/D138685
---
 libcxx/docs/index.rst                                                  | 2 +-
 libcxx/include/__type_traits/is_unsigned.h                             | 3 +--
 libcxx/test/libcxx/atomics/bit-int.verify.cpp                          | 2 +-
 libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp | 2 +-
 libcxx/test/libcxx/transitive_includes.sh.cpp                          | 3 ---
 libcxx/test/std/algorithms/alg.sorting/alg.clamp/ranges.clamp.pass.cpp | 3 ---
 libcxx/test/std/ranges/range.adaptors/range.filter/pred.pass.cpp       | 3 ---
 .../test/std/utilities/format/format.functions/format.locale.pass.cpp  | 2 --
 libcxx/test/std/utilities/format/format.functions/format.pass.cpp      | 2 --
 .../std/utilities/format/format.functions/format_to.locale.pass.cpp    | 2 --
 libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp   | 2 --
 .../std/utilities/format/format.functions/format_to_n.locale.pass.cpp  | 2 --
 libcxx/test/std/utilities/format/format.functions/format_to_n.pass.cpp | 2 --
 .../utilities/format/format.functions/formatted_size.locale.pass.cpp   | 2 --
 .../test/std/utilities/format/format.functions/formatted_size.pass.cpp | 2 --
 .../test/std/utilities/format/format.functions/vformat.locale.pass.cpp | 2 --
 libcxx/test/std/utilities/format/format.functions/vformat.pass.cpp     | 2 --
 .../std/utilities/format/format.functions/vformat_to.locale.pass.cpp   | 2 --
 libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp  | 2 --
 19 files changed, 4 insertions(+), 38 deletions(-)

diff --git a/libcxx/docs/index.rst b/libcxx/docs/index.rst
index f8476c8..db49944 100644
--- a/libcxx/docs/index.rst
+++ b/libcxx/docs/index.rst
@@ -106,7 +106,7 @@ velocity, libc++ drops support for older compilers as newer ones are released.
 Compiler     Versions        Restrictions               Support policy
 ============ =============== ========================== =====================
 Clang        14, 15                                     latest two stable releases per `LLVM's release page <https://releases.llvm.org>`_
-AppleClang   13                                         latest stable release per `Xcode's release page <https://developer.apple.com/documentation/xcode-release-notes>`_
+AppleClang   14                                         latest stable release per `Xcode's release page <https://developer.apple.com/documentation/xcode-release-notes>`_
 Open XL      17.1 (AIX)                                 latest stable release per `Open XL's documentation page <https://www.ibm.com/docs/en/openxl-c-and-cpp-aix>`_
 GCC          12              In C++11 or later only     latest stable release per `GCC's release page <https://gcc.gnu.org/releases.html>`_
 ============ =============== ========================== =====================
diff --git a/libcxx/include/__type_traits/is_unsigned.h b/libcxx/include/__type_traits/is_unsigned.h
index 17cd909..3d75409 100644
--- a/libcxx/include/__type_traits/is_unsigned.h
+++ b/libcxx/include/__type_traits/is_unsigned.h
@@ -20,8 +20,7 @@
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 
-// Before AppleClang 14, __is_unsigned returned true for enums with signed underlying type.
-#if __has_builtin(__is_unsigned) && !(defined(_LIBCPP_APPLE_CLANG_VER) && _LIBCPP_APPLE_CLANG_VER < 1400)
+#if __has_builtin(__is_unsigned)
 
 template<class _Tp>
 struct _LIBCPP_TEMPLATE_VIS is_unsigned : _BoolConstant<__is_unsigned(_Tp)> { };
diff --git a/libcxx/test/libcxx/atomics/bit-int.verify.cpp b/libcxx/test/libcxx/atomics/bit-int.verify.cpp
index 63bed5e..fc6a529 100644
--- a/libcxx/test/libcxx/atomics/bit-int.verify.cpp
+++ b/libcxx/test/libcxx/atomics/bit-int.verify.cpp
@@ -12,7 +12,7 @@
 // disable them for now until their behavior can be designed better later.
 // See https://reviews.llvm.org/D84049 for details.
 
-// UNSUPPORTED: apple-clang-13, apple-clang-14
+// UNSUPPORTED: apple-clang-14
 
 // UNSUPPORTED: c++03
 
diff --git a/libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp b/libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp
index 4d32f2e..5996e0c 100644
--- a/libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp
+++ b/libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp
@@ -16,7 +16,7 @@
 // UNSUPPORTED: clang-14
 
 // AppleClang does not support the -fexperimental-library flag yet
-// UNSUPPORTED: apple-clang-13, apple-clang-14.0
+// UNSUPPORTED: apple-clang-14.0
 
 // Clang on AIX currently pretends that it is Clang 15, even though it is not (as of writing
 // this, LLVM 15 hasn't even been branched yet).
diff --git a/libcxx/test/libcxx/transitive_includes.sh.cpp b/libcxx/test/libcxx/transitive_includes.sh.cpp
index 04c5deb..7733a42 100644
--- a/libcxx/test/libcxx/transitive_includes.sh.cpp
+++ b/libcxx/test/libcxx/transitive_includes.sh.cpp
@@ -27,9 +27,6 @@
 // This test uses --trace-includes, which is not supported by GCC.
 // UNSUPPORTED: gcc
 
-// This test uses -fshow-skipped-includes, which isn't supported on older Clangs
-// UNSUPPORTED: apple-clang-13
-
 // This test doesn't work on AIX, but it should. Needs investigation.
 // XFAIL: buildhost=aix
 
diff --git a/libcxx/test/std/algorithms/alg.sorting/alg.clamp/ranges.clamp.pass.cpp b/libcxx/test/std/algorithms/alg.sorting/alg.clamp/ranges.clamp.pass.cpp
index 9da52e2..036552f 100644
--- a/libcxx/test/std/algorithms/alg.sorting/alg.clamp/ranges.clamp.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.sorting/alg.clamp/ranges.clamp.pass.cpp
@@ -10,9 +10,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 
-// Older Clangs don't properly deduce decltype(auto) with a concept constraint
-// XFAIL: apple-clang-13.0
-
 // template<class T, class Proj = identity,
 //          indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
 //   constexpr const T&
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/pred.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/pred.pass.cpp
index 76522c1..5af3978 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/pred.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/pred.pass.cpp
@@ -8,9 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 
-// Older Clangs don't properly deduce decltype(auto) with a concept constraint
-// XFAIL: apple-clang-13.0
-
 // constexpr Pred const& pred() const;
 
 #include <ranges>
diff --git a/libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp b/libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp
index 12aedf8..a50c416 100644
--- a/libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp
@@ -10,8 +10,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED:gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/format.pass.cpp b/libcxx/test/std/utilities/format/format.functions/format.pass.cpp
index ec9b67d..1bcc216a 100644
--- a/libcxx/test/std/utilities/format/format.functions/format.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/format.pass.cpp
@@ -9,8 +9,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // Note this formatter shows additional information when tests are failing.
 // This aids the development. Since other formatters fail in the same fashion
diff --git a/libcxx/test/std/utilities/format/format.functions/format_to.locale.pass.cpp b/libcxx/test/std/utilities/format/format.functions/format_to.locale.pass.cpp
index b4726c2..1bd6dc8 100644
--- a/libcxx/test/std/utilities/format/format.functions/format_to.locale.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/format_to.locale.pass.cpp
@@ -10,8 +10,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp b/libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
index 04e4f1f..16d2878 100644
--- a/libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
@@ -9,8 +9,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/format_to_n.locale.pass.cpp b/libcxx/test/std/utilities/format/format.functions/format_to_n.locale.pass.cpp
index 6a3a505..ee16552 100644
--- a/libcxx/test/std/utilities/format/format.functions/format_to_n.locale.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/format_to_n.locale.pass.cpp
@@ -10,8 +10,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/format_to_n.pass.cpp b/libcxx/test/std/utilities/format/format.functions/format_to_n.pass.cpp
index 9954bad..e758e65 100644
--- a/libcxx/test/std/utilities/format/format.functions/format_to_n.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/format_to_n.pass.cpp
@@ -9,8 +9,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/formatted_size.locale.pass.cpp b/libcxx/test/std/utilities/format/format.functions/formatted_size.locale.pass.cpp
index 1bde3b6..1317f7f 100644
--- a/libcxx/test/std/utilities/format/format.functions/formatted_size.locale.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/formatted_size.locale.pass.cpp
@@ -10,8 +10,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp b/libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp
index 3d3a638..8f0eae0 100644
--- a/libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp
@@ -9,8 +9,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/vformat.locale.pass.cpp b/libcxx/test/std/utilities/format/format.functions/vformat.locale.pass.cpp
index f23ce2c..c2d53de 100644
--- a/libcxx/test/std/utilities/format/format.functions/vformat.locale.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/vformat.locale.pass.cpp
@@ -10,8 +10,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/vformat.pass.cpp b/libcxx/test/std/utilities/format/format.functions/vformat.pass.cpp
index a2dcf6c..7692e09 100644
--- a/libcxx/test/std/utilities/format/format.functions/vformat.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/vformat.pass.cpp
@@ -9,8 +9,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/vformat_to.locale.pass.cpp b/libcxx/test/std/utilities/format/format.functions/vformat_to.locale.pass.cpp
index c722268..3d1f418 100644
--- a/libcxx/test/std/utilities/format/format.functions/vformat_to.locale.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/vformat_to.locale.pass.cpp
@@ -10,8 +10,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
diff --git a/libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp b/libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
index f003e7b..8a8bf6f 100644
--- a/libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
@@ -9,8 +9,6 @@
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
-// TODO FMT Investigate AppleClang ICE
-// UNSUPPORTED: apple-clang-13
 
 // <format>
 
-- 
2.7.4