From 3906e2b10954632b0c5685bf1a88ae517910c135 Mon Sep 17 00:00:00 2001 From: "erik.corry@gmail.com" Date: Mon, 3 May 2010 09:53:47 +0000 Subject: [PATCH] No implicit conversion between a Foo** and a Handle. Review URL: http://codereview.chromium.org/1861001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4561 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/handles.h | 2 +- src/x64/assembler-x64.cc | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/handles.h b/src/handles.h index 5baceee..ea13def 100644 --- a/src/handles.h +++ b/src/handles.h @@ -42,7 +42,7 @@ namespace internal { template class Handle { public: - INLINE(Handle(T** location)) { location_ = location; } + INLINE(explicit Handle(T** location)) { location_ = location; } INLINE(explicit Handle(T* obj)); INLINE(Handle()) : location_(NULL) {} diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc index 4741351..23b0b70 100644 --- a/src/x64/assembler-x64.cc +++ b/src/x64/assembler-x64.cc @@ -116,8 +116,10 @@ void CpuFeatures::Probe() { CodeDesc desc; assm.GetCode(&desc); - Object* code = - Heap::CreateCode(desc, NULL, Code::ComputeFlags(Code::STUB), NULL); + Object* code = Heap::CreateCode(desc, + NULL, + Code::ComputeFlags(Code::STUB), + Handle()); if (!code->IsCode()) return; PROFILE(CodeCreateEvent(Logger::BUILTIN_TAG, Code::cast(code), "CpuFeatures::Probe")); -- 2.7.4