From 38e30dc631d76c2cd074d449b584ea2c695bb08e Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Tue, 29 Sep 2015 00:25:00 +1000 Subject: [PATCH] gtk: fix assertion when the element has no peer When proxying keyboard/navigation/mouse events, only unref a successfully retreived peer pad. https://bugzilla.gnome.org/show_bug.cgi?id=755738 --- ext/gtk/gstgtkbasesink.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ext/gtk/gstgtkbasesink.c b/ext/gtk/gstgtkbasesink.c index e11627b..dd3af91 100644 --- a/ext/gtk/gstgtkbasesink.c +++ b/ext/gtk/gstgtkbasesink.c @@ -276,10 +276,12 @@ gst_gtk_base_sink_navigation_send_event (GstNavigation * navigation, GST_TRACE_OBJECT (sink, "navigation event %" GST_PTR_FORMAT, structure); - if (GST_IS_PAD (pad) && GST_IS_EVENT (event)) - gst_pad_send_event (pad, event); + if (GST_IS_PAD (pad)) { + if (GST_IS_EVENT (event)) + gst_pad_send_event (pad, event); - gst_object_unref (pad); + gst_object_unref (pad); + } } static void -- 2.7.4