From 38e229b2b3b5cc28c40ae114146bcdb45f60fc46 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 25 Jun 2014 10:23:35 -0600 Subject: [PATCH] change to_info_record to use target delegation This changes to_info_record to use target delegation. Also, target_info_record was unused, so this patch removes it. 2014-07-07 Tom Tromey * target-delegates.c: Rebuild. * target.c (target_info_record): Remove. * record.c (info_record_command): Unconditionally call to_info_record. * target.h (struct target_ops) : Use TARGET_DEFAULT_IGNORE. (target_info_record): Remove. --- gdb/ChangeLog | 10 ++++++++++ gdb/record.c | 3 +-- gdb/target.c | 17 ----------------- gdb/target.h | 6 ++---- 4 files changed, 13 insertions(+), 23 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f799737..f41451a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,15 @@ 2014-07-07 Tom Tromey + * target-delegates.c: Rebuild. + * target.c (target_info_record): Remove. + * record.c (info_record_command): Unconditionally call + to_info_record. + * target.h (struct target_ops) : Use + TARGET_DEFAULT_IGNORE. + (target_info_record): Remove. + +2014-07-07 Tom Tromey + * target.h (struct target_ops) : Use TARGET_DEFAULT_NORETURN. * target.c (generic_tls_error): New function. diff --git a/gdb/record.c b/gdb/record.c index acdbc1a..ff54a8b 100644 --- a/gdb/record.c +++ b/gdb/record.c @@ -285,8 +285,7 @@ info_record_command (char *args, int from_tty) } printf_filtered (_("Active record target: %s\n"), t->to_shortname); - if (t->to_info_record != NULL) - t->to_info_record (t); + t->to_info_record (t); } /* The "record save" command. */ diff --git a/gdb/target.c b/gdb/target.c index 91756c8..c9c5e4b 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -3443,23 +3443,6 @@ target_stop_recording (void) /* See target.h. */ void -target_info_record (void) -{ - struct target_ops *t; - - for (t = current_target.beneath; t != NULL; t = t->beneath) - if (t->to_info_record != NULL) - { - t->to_info_record (t); - return; - } - - tcomplain (); -} - -/* See target.h. */ - -void target_save_record (const char *filename) { current_target.to_save_record (¤t_target, filename); diff --git a/gdb/target.h b/gdb/target.h index cf4ced1..8bf160c 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -1022,7 +1022,8 @@ struct target_ops TARGET_DEFAULT_IGNORE (); /* Print information about the recording. */ - void (*to_info_record) (struct target_ops *); + void (*to_info_record) (struct target_ops *) + TARGET_DEFAULT_IGNORE (); /* Save the recorded execution trace into a file. */ void (*to_save_record) (struct target_ops *, const char *filename) @@ -2221,9 +2222,6 @@ extern enum btrace_error target_read_btrace (VEC (btrace_block_s) **, /* See to_stop_recording in struct target_ops. */ extern void target_stop_recording (void); -/* See to_info_record in struct target_ops. */ -extern void target_info_record (void); - /* See to_save_record in struct target_ops. */ extern void target_save_record (const char *filename); -- 2.7.4