From 388a2682ed05747ff9ad48269df42543da67b2c3 Mon Sep 17 00:00:00 2001 From: Hyeongseok Oh Date: Wed, 29 Mar 2017 17:28:57 +0900 Subject: [PATCH] Fix dependency to coreclr and mscorrc in Linux (dotnet/coreclr#10138) * Fix dependency to coreclr and mscorrc in Linux Remove dependency with coreclr in some projects for Linux Recover build mscorrc for cross architecture in Linux * Fix CMakeLists.txt in src/dlls minimize uses of CLR_CROSS_COMPONENTS_BUILD flag in CMakeLists.txt Modify root/CMakeLists.txt to exclude corerun and coreconsole build during cross component build Commit migrated from https://github.com/dotnet/coreclr/commit/1c4fda612e8a4f0d48346c477d058fa3fddf514e --- src/coreclr/CMakeLists.txt | 2 +- src/coreclr/src/coreclr/hosts/unixcoreconsole/CMakeLists.txt | 4 ---- src/coreclr/src/coreclr/hosts/unixcorerun/CMakeLists.txt | 4 ---- src/coreclr/src/debug/daccess/CMakeLists.txt | 2 +- src/coreclr/src/dlls/CMakeLists.txt | 8 +++----- src/coreclr/src/dlls/mscoree/coreclr/CMakeLists.txt | 4 +++- 6 files changed, 8 insertions(+), 16 deletions(-) diff --git a/src/coreclr/CMakeLists.txt b/src/coreclr/CMakeLists.txt index b371432..c60fa26 100644 --- a/src/coreclr/CMakeLists.txt +++ b/src/coreclr/CMakeLists.txt @@ -542,7 +542,7 @@ include(pgosupport.cmake) # - do not depend on clr's compile definitions #----------------------------------------- if(CLR_CMAKE_PLATFORM_UNIX AND NOT DEFINED CLR_CROSS_COMPONENTS_BUILD) - add_subdirectory(src/corefx) + add_subdirectory(src/corefx) endif() if(CLR_CMAKE_PLATFORM_UNIX) diff --git a/src/coreclr/src/coreclr/hosts/unixcoreconsole/CMakeLists.txt b/src/coreclr/src/coreclr/hosts/unixcoreconsole/CMakeLists.txt index 94587b5..2daeaabf 100644 --- a/src/coreclr/src/coreclr/hosts/unixcoreconsole/CMakeLists.txt +++ b/src/coreclr/src/coreclr/hosts/unixcoreconsole/CMakeLists.txt @@ -31,8 +31,4 @@ if(NOT CLR_CMAKE_PLATFORM_ANDROID) ) endif() -add_dependencies(coreconsole - coreclr -) - install_clr(coreconsole) diff --git a/src/coreclr/src/coreclr/hosts/unixcorerun/CMakeLists.txt b/src/coreclr/src/coreclr/hosts/unixcorerun/CMakeLists.txt index b5dc730..07beaae 100644 --- a/src/coreclr/src/coreclr/hosts/unixcorerun/CMakeLists.txt +++ b/src/coreclr/src/coreclr/hosts/unixcorerun/CMakeLists.txt @@ -32,8 +32,4 @@ if(NOT CLR_CMAKE_PLATFORM_ANDROID) ) endif() -add_dependencies(corerun - coreclr -) - install_clr(corerun) diff --git a/src/coreclr/src/debug/daccess/CMakeLists.txt b/src/coreclr/src/debug/daccess/CMakeLists.txt index c06e946..aab3f81 100644 --- a/src/coreclr/src/debug/daccess/CMakeLists.txt +++ b/src/coreclr/src/debug/daccess/CMakeLists.txt @@ -62,5 +62,5 @@ if(CLR_CMAKE_PLATFORM_UNIX) DEPENDS ${GENERATED_INCLUDE_DIR}/dactablerva.h ) - add_dependencies(daccess coreclr dactablerva_header) + add_dependencies(daccess dactablerva_header) endif(CLR_CMAKE_PLATFORM_UNIX) diff --git a/src/coreclr/src/dlls/CMakeLists.txt b/src/coreclr/src/dlls/CMakeLists.txt index 6d036af..932e65e 100644 --- a/src/coreclr/src/dlls/CMakeLists.txt +++ b/src/coreclr/src/dlls/CMakeLists.txt @@ -4,8 +4,6 @@ endif(WIN32) add_subdirectory(dbgshim) add_subdirectory(mscordbi) add_subdirectory(mscordac) -if (NOT CLR_CROSS_COMPONENTS_BUILD) - add_subdirectory(mscoree) - add_subdirectory(mscorpe) - add_subdirectory(mscorrc) -endif() +add_subdirectory(mscoree) +add_subdirectory(mscorpe) +add_subdirectory(mscorrc) diff --git a/src/coreclr/src/dlls/mscoree/coreclr/CMakeLists.txt b/src/coreclr/src/dlls/mscoree/coreclr/CMakeLists.txt index f2514d2..3144b51 100644 --- a/src/coreclr/src/dlls/mscoree/coreclr/CMakeLists.txt +++ b/src/coreclr/src/dlls/mscoree/coreclr/CMakeLists.txt @@ -171,7 +171,9 @@ if(WIN32) COMMENT Add dactable, debug resources, and dump helper resources to coreclr ) - add_custom_target(inject_debug_resources ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/inject_debug_resources.timestamp) + if(NOT DEFINED CLR_CROSS_COMPONENTS_BUILD) + add_custom_target(inject_debug_resources ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/inject_debug_resources.timestamp) + endif() endif(WIN32) -- 2.7.4