From 38422b135678b85d6a02d9a48e4375a9dcc1368c Mon Sep 17 00:00:00 2001 From: Sebastian Pop Date: Tue, 26 Jul 2016 00:15:08 +0000 Subject: [PATCH] GVN-hoist: limit hoisting depth (PR28670) This patch adds an option to specify the maximum depth in a BB at which to consider hoisting instructions. Hoisting instructions from a deeper level is not profitable as it increases register pressure and compilation time. Differential Revision: https://reviews.llvm.org/D22772 llvm-svn: 276713 --- llvm/lib/Transforms/Scalar/GVNHoist.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/llvm/lib/Transforms/Scalar/GVNHoist.cpp b/llvm/lib/Transforms/Scalar/GVNHoist.cpp index 5a50f54..245fef9 100644 --- a/llvm/lib/Transforms/Scalar/GVNHoist.cpp +++ b/llvm/lib/Transforms/Scalar/GVNHoist.cpp @@ -48,6 +48,11 @@ static cl::opt MaxNumberOfBBSInPath( cl::desc("Max number of basic blocks on the path between " "hoisting locations (default = 4, unlimited = -1)")); +static cl::opt MaxDepthInBB( + "gvn-hoist-max-depth", cl::Hidden, cl::init(100), + cl::desc("Hoist instructions from the beginning of the BB up to the " + "maximum specified depth (default = 100, unlimited = -1)")); + namespace { // Provides a sorting function based on the execution order of two instructions. @@ -765,7 +770,13 @@ private: StoreInfo SI; CallInfo CI; for (BasicBlock *BB : depth_first(&F.getEntryBlock())) { + int InstructionNb = 0; for (Instruction &I1 : *BB) { + // Only hoist the first instructions in BB up to MaxDepthInBB. Hoisting + // deeper may increase the register pressure and compilation time. + if (MaxDepthInBB != -1 && InstructionNb++ >= MaxDepthInBB) + break; + if (auto *Load = dyn_cast(&I1)) LI.insert(Load, VN); else if (auto *Store = dyn_cast(&I1)) -- 2.7.4