From 380e1d918cb4581fae0277ff547d75334f3e7ddd Mon Sep 17 00:00:00 2001 From: Mircea Trofin Date: Tue, 15 Dec 2020 08:40:01 -0800 Subject: [PATCH] [utils] The func_dict for a prefix may just be empty Follow up from D92965 - since we try to find failed prefixes after each RUN line, it's possible the whole list of functions for a prefix be non-existent, which is fine - this happens when none of the RUN lines seen so far used the prefix. --- llvm/utils/UpdateTestChecks/common.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/llvm/utils/UpdateTestChecks/common.py b/llvm/utils/UpdateTestChecks/common.py index 8cd90de..21878e8 100644 --- a/llvm/utils/UpdateTestChecks/common.py +++ b/llvm/utils/UpdateTestChecks/common.py @@ -261,10 +261,10 @@ class function_body(object): def get_failed_prefixes(func_dict): # This returns the list of those prefixes that failed to match any function, # because there were conflicting bodies produced by different RUN lines, in - # all instances of the prefix. Effectivelly, this prefix is unused and should + # all instances of the prefix. Effectively, this prefix is unused and should # be removed. for prefix in func_dict: - if (not [fct for fct in func_dict[prefix] + if func_dict[prefix] and (not [fct for fct in func_dict[prefix] if func_dict[prefix][fct] is not None]): yield prefix -- 2.7.4