From 37df09492c3315c4824e53ebcea781c114be9f41 Mon Sep 17 00:00:00 2001 From: Hui Wang Date: Thu, 29 May 2014 15:59:17 +0800 Subject: [PATCH] Revert "ALSA: hda - drop def association and sequence from pinconf comparing" This reverts commit c687200b9d4ef60042a50f7d942cfef120cc7bf1. Dropping the def association and sequence from pinconf comparing is a bit risky, It will introduce a greater risk of catching unwanted machines. And in addition, so far no BIOS experts give us an explicit answer whether it makes senses to compare these two fields or not. For safety reason, we revert this commit. Signed-off-by: Hui Wang Signed-off-by: Takashi Iwai --- sound/pci/hda/hda_auto_parser.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c index 3cf9137..b684c6e 100644 --- a/sound/pci/hda/hda_auto_parser.c +++ b/sound/pci/hda/hda_auto_parser.c @@ -844,8 +844,7 @@ static bool pin_config_match(struct hda_codec *codec, { for (; pins->nid; pins++) { u32 def_conf = snd_hda_codec_get_pincfg(codec, pins->nid); - u32 mask = 0xffffff00; - if ((pins->val & mask) != (def_conf & mask)) + if (pins->val != def_conf) return false; } return true; -- 2.7.4