From 37a92d0af19a916d432d78ac5af5b2f67e928c8c Mon Sep 17 00:00:00 2001 From: Connor Abbott Date: Wed, 26 Jul 2023 16:02:52 +0200 Subject: [PATCH] tu: Disable transformFeedbackPreservesProvokingVertex Our implementation only preserves the provoking vertex if it is last, and always preserving it would be more draw-time validation because the vertex ordering is tied up with the tessellation domain origin. It turns out we didn't notice this because the tests aren't good enough to catch the issue. Part-of: --- src/freedreno/vulkan/tu_device.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/freedreno/vulkan/tu_device.cc b/src/freedreno/vulkan/tu_device.cc index f8f4465..452c952 100644 --- a/src/freedreno/vulkan/tu_device.cc +++ b/src/freedreno/vulkan/tu_device.cc @@ -497,7 +497,6 @@ tu_get_features(struct tu_physical_device *pdevice, /* VK_EXT_provoking_vertex */ features->provokingVertexLast = true; - features->transformFeedbackPreservesProvokingVertex = true; /* VK_EXT_mutable_descriptor_type */ features->mutableDescriptorType = true; -- 2.7.4