From 376214a1207eb805e75082fe300dfb0421ab4752 Mon Sep 17 00:00:00 2001 From: Artem Bityutskiy Date: Fri, 28 Dec 2012 10:28:22 +0200 Subject: [PATCH] baseimager.py: rename MANIFEST to MD5SUMS The name "MANIFEST" is not very good for multiple reasons: 1. It is not user-friendly - mere users do cannot tell what this file is from its name. 2. Tizen is currently the most important user of MIC, and in Tizen we use word "manifest" for a different thing - every package has a security manifest file which declares the needs of the package. 3. MIC stores checksums in the MANIFEST, and this file is compatible with the 'md5sum' tool. If we decide to provide sha1 checksums in the future, we'll have to add another file with a different name. What will that name be? Anyway, it is nicer and cleaner to use the same naming scheme as OpenSuse and Ubuntu use. They have MD5SUMS and SHA1SUMS files. Let's make things more aligned and cleaner and rename MANIFEST into MD5SUMS. This may break some scripts some people use. But I think it is anyway a low risk thing, and it is better to rename now, when Tizen has few users. It may be more difficult to do later. Change-Id: I79f968066aa27bd211622f477b27a1973b3775ad Signed-off-by: Artem Bityutskiy --- mic/imager/baseimager.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mic/imager/baseimager.py b/mic/imager/baseimager.py index 919420b..60c7e8a 100644 --- a/mic/imager/baseimager.py +++ b/mic/imager/baseimager.py @@ -1189,10 +1189,10 @@ class BaseImageCreator(object): os.rename(_rpath(f), _rpath(newf)) outimages.append(_rpath(newf)) - # generate MANIFEST - with open(_rpath("MANIFEST"), "w") as wf: + # generate MD5SUMS + with open(_rpath("MD5SUMS"), "w") as wf: for f in os.listdir(destdir): - if f == "MANIFEST": + if f == "MD5SUMS": continue if os.path.isdir(os.path.join(destdir, f)): @@ -1201,10 +1201,10 @@ class BaseImageCreator(object): md5sum = misc.get_md5sum(_rpath(f)) # There needs to be two spaces between the sum and # filepath to match the syntax with md5sum. - # This way also md5sum -c MANIFEST can be used by users + # This way also md5sum -c MD5SUMS can be used by users wf.write("%s *%s\n" % (md5sum, f)) - outimages.append("%s/MANIFEST" % destdir) + outimages.append("%s/MD5SUMS" % destdir) # Filter out the nonexist file for fp in outimages[:]: -- 2.7.4