From 3753468682a9c7982b6eba0fca58fbfc1cd5b9fb Mon Sep 17 00:00:00 2001 From: Keith Seitz Date: Tue, 17 Oct 2017 14:15:36 -0700 Subject: [PATCH] Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility A previous patch called gdb_assert_not_reached whenever reading the accessibility of a nested typedef definition. Wisely, Pedro has asked me not do this. This patch changes the previous one so that it issues a complaint instead. gdb/ChangeLog: * dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled DW_AT_accessibility. --- gdb/ChangeLog | 5 +++++ gdb/dwarf2read.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 097b0de..b588641 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-10-18 Keith Seitz + + * dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled + DW_AT_accessibility. + 2017-10-18 Yao Qi * features/tic6x-c62x-linux.c: Remove. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index f27d9b9..686fa3f 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -13131,7 +13131,8 @@ dwarf2_add_typedef (struct field_info *fip, struct die_info *die, fp->is_protected = 1; break; default: - gdb_assert_not_reached ("unexpected accessibility attribute"); + complaint (&symfile_complaints, + _("Unhandled DW_AT_accessibility value (%x)"), accessibility); } new_field->next = fip->typedef_field_list; -- 2.7.4