From 3719fd55b6f89662653d50d33bb267c5f21127a5 Mon Sep 17 00:00:00 2001 From: "Jose E. Marchesi" Date: Mon, 15 Jul 2019 16:00:28 +0200 Subject: [PATCH] cpu,opcodes,gas: fix explicit arguments to eBPF ldabs instructions This patch fixes the eBPF CPU description in order to reflect the right explicit arguments passed to the ldabs{b,h,w,dw} instructions, updates the corresponding GAS tests, and updates the BPF section of the GAS manual. cpu/ChangeLog: 2019-07-15 Jose E. Marchesi * bpf.cpu (dlabs): New pmacro. (dlind): Likewise. opcodes/ChangeLog: 2019-07-15 Jose E. Marchesi * bpf-desc.c: Regenerate. * bpf-opc.c: Likewise. * bpf-opc.h: Likewise. gas/ChangeLog: 2019-07-15 Jose E. Marchesi * testsuite/gas/bpf/mem.s: ldabs instructions do not take a `src' register as an argument. * testsuite/gas/bpf/mem.d: Updated accordingly. * testsuite/gas/bpf/mem-be.d: Likewise. * doc/c-bpf.texi (BPF Opcodes): Update to reflect the correct explicit arguments to ldabs and ldind instructions. --- cpu/ChangeLog | 5 +++ cpu/bpf.cpu | 63 +++++++++++++++++++++--------------- gas/ChangeLog | 9 ++++++ gas/doc/c-bpf.texi | 16 +++++----- gas/testsuite/gas/bpf/mem-be.d | 8 ++--- gas/testsuite/gas/bpf/mem.d | 8 ++--- gas/testsuite/gas/bpf/mem.s | 8 ++--- opcodes/ChangeLog | 6 ++++ opcodes/bpf-desc.c | 44 +++++++------------------- opcodes/bpf-opc.c | 72 +++++++++++++++--------------------------- opcodes/bpf-opc.h | 7 ++-- 11 files changed, 119 insertions(+), 127 deletions(-) diff --git a/cpu/ChangeLog b/cpu/ChangeLog index 4994003..41d008f 100644 --- a/cpu/ChangeLog +++ b/cpu/ChangeLog @@ -1,3 +1,8 @@ +2019-07-15 Jose E. Marchesi + + * bpf.cpu (dlabs): New pmacro. + (dlind): Likewise. + 2019-07-14 Jose E. Marchesi * bpf.cpu (dlsi): ldabs and ldind instructions do not take an diff --git a/cpu/bpf.cpu b/cpu/bpf.cpu index 60e89fb..b8a3a92 100644 --- a/cpu/bpf.cpu +++ b/cpu/bpf.cpu @@ -466,36 +466,49 @@ (define-lddw le) (define-lddw be) -;; The absolute/indirect load instructions are non-generic loads -;; designed to be used in socket filters. They come in several -;; variants: +;; The absolute load instructions are non-generic loads designed to be +;; used in socket filters. They come in several variants: +;; +;; LDABS{w,h,b,dw} + +(define-pmacro (dlabs x-suffix x-size) + (dni (.sym "ldabs" x-suffix) + (.str "ldabs" x-suffix) + (all-isas) + (.str "ldabs" x-suffix " $imm32") + (+ imm32 (f-offset16 0) (f-regs 0) + OP_CLASS_LD OP_MODE_ABS (.sym OP_SIZE_ x-size)) + () ())) + +(dlabs "w" W) +(dlabs "h" H) +(dlabs "b" B) +(dlabs "dw" DW) + +;; The indirect load instructions are non-generic loads designed to be +;; used in socket filters. They come in several variants: ;; -;; LD{abs,ind}{w,h,b,dw}le for the little-endian ISA -;; LD{abs,ind}[w,h,b,dw}be for the big-endian ISA +;; LDIND{w,h,b,dw}le for the little-endian ISA +;; LDIND[w,h,b,dw}be for the big-endian ISA -(define-pmacro (dlsi x-basename x-suffix x-class x-size x-mode x-endian) - (dni (.sym x-basename x-suffix x-endian) - (.str x-basename x-suffix) +(define-pmacro (dlind x-suffix x-size x-endian) + (dni (.sym "ldind" x-suffix x-endian) + (.str "ldind" x-suffix) ((ISA (.sym ebpf x-endian))) - (.str x-basename x-suffix " $src" x-endian ",$imm32") + (.str "ldind" x-suffix " $src" x-endian ",$imm32") (+ imm32 (f-offset16 0) ((.sym f-dst x-endian) 0) (.sym src x-endian) - (.sym OP_CLASS_ x-class) (.sym OP_SIZE_ x-size) - (.sym OP_MODE_ x-mode)) () ())) + OP_CLASS_LD OP_MODE_IND (.sym OP_SIZE_ x-size)) + () ())) -(define-pmacro (define-ldabsind x-endian) - (begin - (dlsi "ldabs" "w" LD W ABS x-endian) - (dlsi "ldabs" "h" LD H ABS x-endian) - (dlsi "ldabs" "b" LD B ABS x-endian) - (dlsi "ldabs" "dw" LD DW ABS x-endian) - - (dlsi "ldind" "w" LD W IND x-endian) - (dlsi "ldind" "h" LD H IND x-endian) - (dlsi "ldind" "b" LD B IND x-endian) - (dlsi "ldind" "dw" LD DW IND x-endian))) - -(define-ldabsind le) -(define-ldabsind be) +(define-pmacro (define-ldind x-endian) + (begin + (dlind "w" W x-endian) + (dlind "h" H x-endian) + (dlind "b" B x-endian) + (dlind "dw" DW x-endian))) + +(define-ldind le) +(define-ldind be) ;; Generic load and store instructions are provided for several word ;; sizes. They come in several variants: diff --git a/gas/ChangeLog b/gas/ChangeLog index fb44aa3..2d8a997 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,12 @@ +2019-07-15 Jose E. Marchesi + + * testsuite/gas/bpf/mem.s: ldabs instructions do not take a `src' + register as an argument. + * testsuite/gas/bpf/mem.d: Updated accordingly. + * testsuite/gas/bpf/mem-be.d: Likewise. + * doc/c-bpf.texi (BPF Opcodes): Update to reflect the correct + explicit arguments to ldabs and ldind instructions. + 2019-07-14 Jose E. Marchesi * testsuite/gas/bpf/mem.s: Do not use explicit arguments for diff --git a/gas/doc/c-bpf.texi b/gas/doc/c-bpf.texi index a7a694f..13f4144 100644 --- a/gas/doc/c-bpf.texi +++ b/gas/doc/c-bpf.texi @@ -234,26 +234,26 @@ tree for more information. Absolute loads: @table @code -@item ldabsdw %d, %s, imm32 +@item ldabsdw imm32 Absolute 64-bit load. -@item ldabsw %d, %s, imm32 +@item ldabsw imm32 Absolute 32-bit load. -@item ldabsh %d, %s, imm32 +@item ldabsh imm32 Absolute 16-bit load. -@item ldabsb %d, %s, imm32 +@item ldabsb imm32 Absolute 8-bit load. @end table Indirect loads: @table @code -@item ldinddw %d, %s, imm32 +@item ldinddw %s, imm32 Indirect 64-bit load. -@item ldindw %d, %s, imm32 +@item ldindw %s, imm32 Indirect 32-bit load. -@item ldindh %d, %s, imm32 +@item ldindh %s, imm32 Indirect 16-bit load. -@item ldindb %d, %s, imm32 +@item ldindb %s, imm32 Indirect 8-bit load. @end table diff --git a/gas/testsuite/gas/bpf/mem-be.d b/gas/testsuite/gas/bpf/mem-be.d index 7a258bc..b3dba80 100644 --- a/gas/testsuite/gas/bpf/mem-be.d +++ b/gas/testsuite/gas/bpf/mem-be.d @@ -8,10 +8,10 @@ Disassembly of section .text: 0+ <.text>: - 0: 20 03 00 00 00 00 be ef ldabsw %r3,0xbeef - 8: 28 05 00 00 00 00 be ef ldabsh %r5,0xbeef - 10: 30 07 00 00 00 00 be ef ldabsb %r7,0xbeef - 18: 38 09 00 00 00 00 be ef ldabsdw %r9,0xbeef + 0: 20 00 00 00 00 00 be ef ldabsw 0xbeef + 8: 28 00 00 00 00 00 be ef ldabsh 0xbeef + 10: 30 00 00 00 00 00 be ef ldabsb 0xbeef + 18: 38 00 00 00 00 00 be ef ldabsdw 0xbeef 20: 40 03 00 00 00 00 be ef ldindw %r3,0xbeef 28: 48 05 00 00 00 00 be ef ldindh %r5,0xbeef 30: 50 07 00 00 00 00 be ef ldindb %r7,0xbeef diff --git a/gas/testsuite/gas/bpf/mem.d b/gas/testsuite/gas/bpf/mem.d index 4587ffd..0e0b498 100644 --- a/gas/testsuite/gas/bpf/mem.d +++ b/gas/testsuite/gas/bpf/mem.d @@ -7,10 +7,10 @@ Disassembly of section .text: 0+ <.text>: - 0: 20 30 00 00 ef be 00 00 ldabsw %r3,0xbeef - 8: 28 50 00 00 ef be 00 00 ldabsh %r5,0xbeef - 10: 30 70 00 00 ef be 00 00 ldabsb %r7,0xbeef - 18: 38 90 00 00 ef be 00 00 ldabsdw %r9,0xbeef + 0: 20 00 00 00 ef be 00 00 ldabsw 0xbeef + 8: 28 00 00 00 ef be 00 00 ldabsh 0xbeef + 10: 30 00 00 00 ef be 00 00 ldabsb 0xbeef + 18: 38 00 00 00 ef be 00 00 ldabsdw 0xbeef 20: 40 30 00 00 ef be 00 00 ldindw %r3,0xbeef 28: 48 50 00 00 ef be 00 00 ldindh %r5,0xbeef 30: 50 70 00 00 ef be 00 00 ldindb %r7,0xbeef diff --git a/gas/testsuite/gas/bpf/mem.s b/gas/testsuite/gas/bpf/mem.s index f0f1d08..af6f41b 100644 --- a/gas/testsuite/gas/bpf/mem.s +++ b/gas/testsuite/gas/bpf/mem.s @@ -2,10 +2,10 @@ .text - ldabsw %r3, 0xbeef - ldabsh %r5, 0xbeef - ldabsb %r7, 0xbeef - ldabsdw %r9, 0xbeef + ldabsw 0xbeef + ldabsh 0xbeef + ldabsb 0xbeef + ldabsdw 0xbeef ldindw %r3, 0xbeef ldindh %r5, 0xbeef ldindb %r7, 0xbeef diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index e1de65b..c00cb8a 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,9 @@ +2019-07-15 Jose E. Marchesi + + * bpf-desc.c: Regenerate. + * bpf-opc.c: Likewise. + * bpf-opc.h: Likewise. + 2019-07-14 Jose E. Marchesi * bpf-desc.c: Regenerate. diff --git a/opcodes/bpf-desc.c b/opcodes/bpf-desc.c index 3b94335..18ded6e 100644 --- a/opcodes/bpf-desc.c +++ b/opcodes/bpf-desc.c @@ -824,25 +824,25 @@ static const CGEN_IBASE bpf_cgen_insn_table[MAX_INSNS] = BPF_INSN_LDDWBE, "lddwbe", "lddw", 128, { 0, { { { (1<