From 371036236feb62d7edf1bb67242fec9c5d5255f8 Mon Sep 17 00:00:00 2001 From: Changgyu Choi Date: Thu, 26 Jan 2023 09:57:00 +0900 Subject: [PATCH] Remove exception handling from _consumeCommnad() This patch removes the catch clause so that the parcel parsing error can be propagated to the user code (as an unhandled exception) properly. Change-Id: Id7e7bc1d11061a5140c51fde156873618fde712c Signed-off-by: Changgyu Choi --- idlc/gen/dart_proxy_gen_cb.h | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/idlc/gen/dart_proxy_gen_cb.h b/idlc/gen/dart_proxy_gen_cb.h index 4184c58..4ee55cc 100644 --- a/idlc/gen/dart_proxy_gen_cb.h +++ b/idlc/gen/dart_proxy_gen_cb.h @@ -81,17 +81,13 @@ class extends ProxyBase { } Parcel _consumeCommand(Port port) { - try { - final Parcel parcel = Parcel.fromPort(port); - final int cmd = parcel.readInt32(); - if (cmd != _MethodId.result.id) { - print('Received parcel is invalid. $cmd'); - } - return parcel; - } catch (error) { - print(error.toString()); - return Parcel(); + final Parcel parcel = Parcel.fromPort(port); + final int cmd = parcel.readInt32(); + if (cmd != _MethodId.result.id) { + print('Received parcel is invalid. $cmd'); } + + return parcel; } /// Disposes of registered delegate interface. -- 2.7.4