From 36ed1f611bba0748f7feb0e0ce6f3b395b25cc1f Mon Sep 17 00:00:00 2001 From: "ager@chromium.org" Date: Mon, 25 Oct 2010 08:22:23 +0000 Subject: [PATCH] Use return value from fwrite in log.cc to please compilers. BUG=453 Review URL: http://codereview.chromium.org/4002005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/log.cc | 6 ++++-- src/platform-macos.cc | 6 +++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/log.cc b/src/log.cc index 1b0fdeb..804db0e 100644 --- a/src/log.cc +++ b/src/log.cc @@ -1378,8 +1378,10 @@ void Logger::LogCodeInfo() { void Logger::LowLevelCodeCreateEvent(Code* code, LogMessageBuilder* msg) { if (!FLAG_ll_prof || Log::output_code_handle_ == NULL) return; int pos = static_cast(ftell(Log::output_code_handle_)); - fwrite(code->instruction_start(), 1, code->instruction_size(), - Log::output_code_handle_); + int rv = fwrite(code->instruction_start(), 1, code->instruction_size(), + Log::output_code_handle_); + ASSERT(static_cast(code->instruction_size()) == rv); + USE(rv); msg->Append(",%d", pos); } diff --git a/src/platform-macos.cc b/src/platform-macos.cc index 3e4daf3..5e0e78d 100644 --- a/src/platform-macos.cc +++ b/src/platform-macos.cc @@ -206,7 +206,11 @@ OS::MemoryMappedFile* OS::MemoryMappedFile::create(const char* name, int size, void* initial) { FILE* file = fopen(name, "w+"); if (file == NULL) return NULL; - fwrite(initial, size, 1, file); + int result = fwrite(initial, size, 1, file); + if (result < 1) { + fclose(file); + return NULL; + } void* memory = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fileno(file), 0); return new PosixMemoryMappedFile(file, memory, size); -- 2.7.4