From 35e39f4145420d8b2d14f93e91633cfceffe4540 Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Sun, 24 Jul 2016 18:21:07 +0900 Subject: [PATCH] edje entry - fix coverity CID 1357752 fix potential crash if calloc fails and sel is NULL @fix --- src/lib/edje/edje_entry.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/lib/edje/edje_entry.c b/src/lib/edje/edje_entry.c index bfb77d1..cb9f732 100644 --- a/src/lib/edje/edje_entry.c +++ b/src/lib/edje/edje_entry.c @@ -1122,19 +1122,25 @@ _anchors_update(Evas_Textblock_Cursor *c EINA_UNUSED, Evas_Object *o, Entry *en) Evas_Object *ob; sel = calloc(1, sizeof(Sel)); - an->sel = eina_list_append(an->sel, sel); - - if (ed->item_provider.func) + if (sel) { - ob = _item_obj_get(an, o, smart, clip); - sel->obj = ob; + an->sel = eina_list_append(an->sel, sel); + + if (ed->item_provider.func) + { + ob = _item_obj_get(an, o, smart, clip); + sel->obj = ob; + } } } - /* We have only one sel per item */ - sel = an->sel->data; - evas_object_move(sel->obj, x + cx, y + cy); - evas_object_resize(sel->obj, cw, ch); - evas_object_show(sel->obj); + if (sel) + { + /* We have only one sel per item */ + sel = an->sel->data; + evas_object_move(sel->obj, x + cx, y + cy); + evas_object_resize(sel->obj, cw, ch); + evas_object_show(sel->obj); + } } // for link anchors else -- 2.7.4