From 359b0c7d592235d44651b77aef7b0f6678ed3472 Mon Sep 17 00:00:00 2001 From: MyungJoo Ham Date: Wed, 11 Oct 2023 16:30:56 +0900 Subject: [PATCH] filter: handle error of convert_to_meta gst_tensor_info_convert_to_meta may return error if the configured output tensor is invalid. Handle the error before feeding it to another function, that may access uninitialized value. Signed-off-by: MyungJoo Ham --- gst/nnstreamer/tensor_filter/tensor_filter.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gst/nnstreamer/tensor_filter/tensor_filter.c b/gst/nnstreamer/tensor_filter/tensor_filter.c index f07334a..9c08d63 100644 --- a/gst/nnstreamer/tensor_filter/tensor_filter.c +++ b/gst/nnstreamer/tensor_filter/tensor_filter.c @@ -771,8 +771,15 @@ gst_tensor_filter_transform (GstBaseTransform * trans, hsize = 0; if (out_flexible && !priv->prop.invoke_dynamic) { - gst_tensor_info_convert_to_meta (&prop->output_meta.info[i], + gboolean ret = FALSE; + ret = gst_tensor_info_convert_to_meta (&prop->output_meta.info[i], &out_meta[i]); + if (TRUE != ret) { + ml_loge_stacktrace + ("gst_tensor_filter_transform: The configured output tensor information is invalid, at %u'th output tensor\n", + i); + goto mem_map_error; + } hsize = gst_tensor_meta_info_get_header_size (&out_meta[i]); } -- 2.7.4