From 351a711ce9a9771f61555b5057d4f249d9afc423 Mon Sep 17 00:00:00 2001 From: Kenneth Reitz Date: Sun, 25 Sep 2011 20:36:39 -0400 Subject: [PATCH] cleanup --- requests/config.py | 33 ++++++++++++++++++++------------- requests/core.py | 1 - requests/models.py | 9 ++++----- 3 files changed, 24 insertions(+), 19 deletions(-) diff --git a/requests/config.py b/requests/config.py index 5bf49b4..a9cfbec 100644 --- a/requests/config.py +++ b/requests/config.py @@ -4,7 +4,7 @@ requests.config ~~~~~~~~~~~~~~~ -This module provides the Requests settings feature set. +This module provides the Requests configuration defaults. settings parameters: @@ -18,27 +18,34 @@ settings parameters: """ -def merge_configs(config, default_config=None): - """Merge two given configurations.""" +def get_config(config=None, default_config=None): + """Merges two given configurations.""" + + # Allow raw calls. + if config is None: + config=dict() # Use the module-level defaults, if none is given. if default_config is None: - default_config = config.copy() + default_config = defaults.copy() + d = default_config.copy() d.update(config) return d + # Module-level defaults. -config = dict() - -config['base_headers'] = {'User-Agent': 'python-requests.org'} -config['accept_gzip'] = True -config['proxies'] = {} -config['verbose'] = None -config['timeout'] = None -config['max_redirects'] = 30 -config['decode_unicode'] = True +defaults = dict() + +defaults['base_headers'] = {'User-Agent': 'python-requests.org'} +defaults['accept_gzip'] = True +defaults['proxies'] = {} +defaults['verbose'] = None +defaults['timeout'] = None +defaults['max_redirects'] = 30 +defaults['decode_unicode'] = True +defaults['keepalive'] = True diff --git a/requests/core.py b/requests/core.py index 477f39d..0278f33 100644 --- a/requests/core.py +++ b/requests/core.py @@ -20,7 +20,6 @@ __copyright__ = 'Copyright 2011 Kenneth Reitz' from api import * -from config import settings from exceptions import * from models import Request, Response from sessions import session diff --git a/requests/models.py b/requests/models.py index 9ebd18d..4f4ee94 100644 --- a/requests/models.py +++ b/requests/models.py @@ -7,18 +7,15 @@ requests.models """ import urllib -import urllib2 -import socket import zlib from urlparse import urlparse, urlunparse, urljoin -from datetime import datetime from .packages import urllib3 # print dir(urllib3) -from .config import settings +from .config import get_config from .structures import CaseInsensitiveDict from .utils import * from .status_codes import codes @@ -36,7 +33,7 @@ class Request(object): def __init__(self, url=None, headers=dict(), files=None, method=None, data=dict(), params=dict(), auth=None, cookies=None, timeout=None, redirect=False, - allow_redirects=False, proxies=None): + allow_redirects=False, proxies=None, config=None): #: Float describ the timeout of the request. # (Use socket.setdefaulttimeout() as fallback) @@ -72,6 +69,8 @@ class Request(object): # Dictionary mapping protocol to the URL of the proxy (e.g. {'http': 'foo.bar:3128'}) self.proxies = proxies + self.config = get_config(config) + self.data = data self._enc_data = encode_params(data) self.params = params -- 2.34.1