From 34abd91e90edd1ee438fd3a797bb5df9e142f1e5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Thu, 30 Oct 2014 23:14:59 +0000 Subject: [PATCH] tests: fix out-of-bounds memory access in bytereader unit test Caught by -fsanitize=address / libasan. https://bugzilla.gnome.org/show_bug.cgi?id=739431 --- tests/check/libs/bytereader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/check/libs/bytereader.c b/tests/check/libs/bytereader.c index 471e6a6..fd4f95d 100644 --- a/tests/check/libs/bytereader.c +++ b/tests/check/libs/bytereader.c @@ -722,7 +722,8 @@ GST_START_TEST (test_sub_reader) fail_unless_equals_int (gst_byte_reader_get_remaining (&sub), 13); fail_unless (gst_byte_reader_peek_data (&reader, 13, &data)); fail_unless (gst_byte_reader_peek_data (&sub, 13, &sub_data)); - fail_unless (memcmp (data, sub_data, 16) == 0); + fail_unless (memcmp (data, sub_data, 13) == 0); + fail_unless (memcmp (memdata + 3, sub_data, 13) == 0); fail_unless_equals_int (gst_byte_reader_get_remaining (&reader), 13); fail_unless (gst_byte_reader_peek_sub_reader (&reader, &sub, 3)); -- 2.7.4