From 344afa853fcfcc085cb5c957b4a07c7ea013bb1b Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Sat, 23 Jan 2021 11:03:43 +0000 Subject: [PATCH] [Support] TrigramIndex::insert - pass std::String argument by const reference. NFCI. Avoid string copies and fix clang-tidy warning. --- llvm/include/llvm/Support/TrigramIndex.h | 2 +- llvm/lib/Support/TrigramIndex.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/llvm/include/llvm/Support/TrigramIndex.h b/llvm/include/llvm/Support/TrigramIndex.h index 360ab94..0be6a10 100644 --- a/llvm/include/llvm/Support/TrigramIndex.h +++ b/llvm/include/llvm/Support/TrigramIndex.h @@ -38,7 +38,7 @@ class StringRef; class TrigramIndex { public: /// Inserts a new Regex into the index. - void insert(std::string Regex); + void insert(const std::string &Regex); /// Returns true, if special case list definitely does not have a line /// that matches the query. Returns false, if it's not sure. diff --git a/llvm/lib/Support/TrigramIndex.cpp b/llvm/lib/Support/TrigramIndex.cpp index 1f1f302..4370adc 100644 --- a/llvm/lib/Support/TrigramIndex.cpp +++ b/llvm/lib/Support/TrigramIndex.cpp @@ -25,7 +25,7 @@ static bool isAdvancedMetachar(unsigned Char) { return strchr(RegexAdvancedMetachars, Char) != nullptr; } -void TrigramIndex::insert(std::string Regex) { +void TrigramIndex::insert(const std::string &Regex) { if (Defeated) return; std::set Was; unsigned Cnt = 0; -- 2.7.4