From 343d66285c97eaf2ee331c45a810c49eedbc8d50 Mon Sep 17 00:00:00 2001 From: Prachi Kumar Date: Sat, 19 Oct 2019 01:24:32 +0530 Subject: [PATCH] Resolved svace issues 413046 to 413057 Change-Id: Ib93612ee9687fb55713467cb4c9edc581d8c8bd4 --- src/apps_data.c | 1 + src/apps_db.c | 5 +++++ src/apps_package_manager.c | 2 -- src/cluster_data.c | 1 + src/cluster_db.c | 3 +++ 5 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/apps_data.c b/src/apps_data.c index 090c9c6..0c05153 100755 --- a/src/apps_data.c +++ b/src/apps_data.c @@ -480,6 +480,7 @@ static void __apps_data_item_free(app_data_t *item) free(item->uri); if (item) free(item); + item = NULL; } static void __apps_data_print(Eina_List *list) diff --git a/src/apps_db.c b/src/apps_db.c index 7079ad8..246d062 100755 --- a/src/apps_db.c +++ b/src/apps_db.c @@ -266,6 +266,7 @@ bool apps_db_update(app_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", UPDATE_APPS_DB_TABLE, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); return false; } @@ -304,6 +305,7 @@ bool apps_db_insert(app_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", INSERT_APPS_DB_TABLE, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); return false; } sqlite3_finalize(stmt); @@ -331,6 +333,7 @@ bool apps_db_delete(app_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", query, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); return false; } @@ -359,6 +362,7 @@ bool apps_db_delete_by_app_id(const char* app_id) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", query, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); return false; } sqlite3_finalize(stmt); @@ -386,6 +390,7 @@ bool apps_db_delete_by_pkg_id(const char* pkg_id) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", query, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); return false; } sqlite3_finalize(stmt); diff --git a/src/apps_package_manager.c b/src/apps_package_manager.c index 9e6db34..1c48d05 100755 --- a/src/apps_package_manager.c +++ b/src/apps_package_manager.c @@ -243,7 +243,6 @@ static bool __apps_package_manager_get_internal_item(app_info_h app_handle, void item->storage_type = INTERNAL; *list = eina_list_append(*list, item); } - usleep(1); return true; } @@ -255,7 +254,6 @@ static bool __apps_package_manager_get_external_item(app_info_h app_handle, void item->storage_type = EXTERNAL; *list = eina_list_append(*list, item); } - usleep(1); return true; } diff --git a/src/cluster_data.c b/src/cluster_data.c index b84f23d..9dbf05f 100755 --- a/src/cluster_data.c +++ b/src/cluster_data.c @@ -163,6 +163,7 @@ static void __cluster_data_item_free(widget_data_t *item) free(item->content_info); if (item) free(item); + item = NULL; } diff --git a/src/cluster_db.c b/src/cluster_db.c index f7a68e9..effb5ea 100755 --- a/src/cluster_db.c +++ b/src/cluster_db.c @@ -174,6 +174,7 @@ bool cluster_db_update(widget_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", UPDATE_CLUSTER_DB_TABLE, sqlite3_errmsg(cluster_db)); + sqlite3_finalize(stmt); return false; } @@ -208,6 +209,7 @@ bool cluster_db_insert(widget_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", INSERT_CLUSTER_DB_TABLE, sqlite3_errmsg(cluster_db)); + sqlite3_finalize(stmt); return false; } @@ -238,6 +240,7 @@ bool cluster_db_delete(widget_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", query, sqlite3_errmsg(cluster_db)); + sqlite3_finalize(stmt); return false; } sqlite3_finalize(stmt); -- 2.7.4