From 3413a66c384f91f08185e1f88dad9adca6189586 Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Mon, 24 Sep 2018 17:18:32 +0000 Subject: [PATCH] [Analysis] add comment to generalize finding a scalar op from vector; NFC llvm-svn: 342906 --- llvm/lib/Analysis/VectorUtils.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/llvm/lib/Analysis/VectorUtils.cpp b/llvm/lib/Analysis/VectorUtils.cpp index 2f4f72a..c639f36 100644 --- a/llvm/lib/Analysis/VectorUtils.cpp +++ b/llvm/lib/Analysis/VectorUtils.cpp @@ -280,9 +280,10 @@ Value *llvm::findScalarElement(Value *V, unsigned EltNo) { } // Extract a value from a vector add operation with a constant zero. - Value *Val = nullptr; Constant *Con = nullptr; - if (match(V, m_Add(m_Value(Val), m_Constant(Con)))) - if (Constant *Elt = Con->getAggregateElement(EltNo)) + // TODO: Use getBinOpIdentity() to generalize this. + Value *Val; Constant *C; + if (match(V, m_Add(m_Value(Val), m_Constant(C)))) + if (Constant *Elt = C->getAggregateElement(EltNo)) if (Elt->isNullValue()) return findScalarElement(Val, EltNo); -- 2.7.4