From 33a3139f809818b39f5786c7505066fc07449a67 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Tue, 3 Jan 2023 14:52:15 +0100 Subject: [PATCH] [CGP] Avoid branch on poison UB in test (NFC) --- .../CodeGenPrepare/AArch64/sink-free-instructions.ll | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/llvm/test/Transforms/CodeGenPrepare/AArch64/sink-free-instructions.ll b/llvm/test/Transforms/CodeGenPrepare/AArch64/sink-free-instructions.ll index 039d098..acba833 100644 --- a/llvm/test/Transforms/CodeGenPrepare/AArch64/sink-free-instructions.ll +++ b/llvm/test/Transforms/CodeGenPrepare/AArch64/sink-free-instructions.ll @@ -401,10 +401,10 @@ for.cond4.preheader.preheader: ; preds = %for.cond4.preheader declare <8 x i16> @llvm.aarch64.neon.pmull.v8i16(<8 x i8>, <8 x i8>) -define <8 x i16> @sink_shufflevector_pmull(<16 x i8> %a, <16 x i8> %b) { +define <8 x i16> @sink_shufflevector_pmull(<16 x i8> %a, <16 x i8> %b, i1 %c) { ; CHECK-LABEL: @sink_shufflevector_pmull( ; CHECK-NEXT: entry: -; CHECK-NEXT: br i1 poison, label [[IF_THEN:%.*]], label [[IF_ELSE:%.*]] +; CHECK-NEXT: br i1 [[C:%.*]], label [[IF_THEN:%.*]], label [[IF_ELSE:%.*]] ; CHECK: if.then: ; CHECK-NEXT: [[TMP0:%.*]] = shufflevector <16 x i8> [[A:%.*]], <16 x i8> poison, <8 x i32> ; CHECK-NEXT: [[S2:%.*]] = shufflevector <16 x i8> [[B:%.*]], <16 x i8> poison, <8 x i32> @@ -419,7 +419,7 @@ define <8 x i16> @sink_shufflevector_pmull(<16 x i8> %a, <16 x i8> %b) { entry: %s1 = shufflevector <16 x i8> %a, <16 x i8> poison, <8 x i32> %s3 = shufflevector <16 x i8> %a, <16 x i8> poison, <8 x i32> - br i1 poison, label %if.then, label %if.else + br i1 %c, label %if.then, label %if.else if.then: %s2 = shufflevector <16 x i8> %b, <16 x i8> poison, <8 x i32> @@ -433,12 +433,12 @@ if.else: } ; Indexed pmull is not available on aarch64. Shuffle vector should not be sunk here. -define <8 x i16> @no_sink_splatvector_pmull(<16 x i8> %a, <16 x i8> %b) { +define <8 x i16> @no_sink_splatvector_pmull(<16 x i8> %a, <16 x i8> %b, i1 %c) { ; CHECK-LABEL: @no_sink_splatvector_pmull( ; CHECK-NEXT: entry: ; CHECK-NEXT: [[S1:%.*]] = shufflevector <16 x i8> [[A:%.*]], <16 x i8> poison, <8 x i32> ; CHECK-NEXT: [[S3:%.*]] = shufflevector <16 x i8> [[A]], <16 x i8> poison, <8 x i32> -; CHECK-NEXT: br i1 poison, label [[IF_THEN:%.*]], label [[IF_ELSE:%.*]] +; CHECK-NEXT: br i1 [[C:%.*]], label [[IF_THEN:%.*]], label [[IF_ELSE:%.*]] ; CHECK: if.then: ; CHECK-NEXT: [[S2:%.*]] = shufflevector <16 x i8> [[B:%.*]], <16 x i8> poison, <8 x i32> ; CHECK-NEXT: [[VMULL0:%.*]] = tail call <8 x i16> @llvm.aarch64.neon.pmull.v8i16(<8 x i8> [[S1]], <8 x i8> [[S2]]) @@ -451,7 +451,7 @@ define <8 x i16> @no_sink_splatvector_pmull(<16 x i8> %a, <16 x i8> %b) { entry: %s1 = shufflevector <16 x i8> %a, <16 x i8> poison, <8 x i32> %s3 = shufflevector <16 x i8> %a, <16 x i8> poison, <8 x i32> - br i1 poison, label %if.then, label %if.else + br i1 %c, label %if.then, label %if.else if.then: %s2 = shufflevector <16 x i8> %b, <16 x i8> poison, <8 x i32> @@ -465,12 +465,12 @@ if.else: } ; Mask used are not suitable for pmull. Shuffle vector should not be sunk here. -define <8 x i16> @no_sink_shufflevector_pmull(<16 x i8> %a, <16 x i8> %b) { +define <8 x i16> @no_sink_shufflevector_pmull(<16 x i8> %a, <16 x i8> %b, i1 %c) { ; CHECK-LABEL: @no_sink_shufflevector_pmull( ; CHECK-NEXT: entry: ; CHECK-NEXT: [[S1:%.*]] = shufflevector <16 x i8> [[A:%.*]], <16 x i8> poison, <8 x i32> ; CHECK-NEXT: [[S3:%.*]] = shufflevector <16 x i8> [[A]], <16 x i8> poison, <8 x i32> -; CHECK-NEXT: br i1 poison, label [[IF_THEN:%.*]], label [[IF_ELSE:%.*]] +; CHECK-NEXT: br i1 [[C:%.*]], label [[IF_THEN:%.*]], label [[IF_ELSE:%.*]] ; CHECK: if.then: ; CHECK-NEXT: [[S2:%.*]] = shufflevector <16 x i8> [[B:%.*]], <16 x i8> poison, <8 x i32> ; CHECK-NEXT: [[VMULL0:%.*]] = tail call <8 x i16> @llvm.aarch64.neon.pmull.v8i16(<8 x i8> [[S1]], <8 x i8> [[S2]]) @@ -483,7 +483,7 @@ define <8 x i16> @no_sink_shufflevector_pmull(<16 x i8> %a, <16 x i8> %b) { entry: %s1 = shufflevector <16 x i8> %a, <16 x i8> poison, <8 x i32> %s3 = shufflevector <16 x i8> %a, <16 x i8> poison, <8 x i32> - br i1 poison, label %if.then, label %if.else + br i1 %c, label %if.then, label %if.else if.then: %s2 = shufflevector <16 x i8> %b, <16 x i8> poison, <8 x i32> -- 2.7.4