From 33680a38001c69112c192cb2ff1359dcbd67ab96 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 24 Jan 2019 10:14:36 +0200 Subject: [PATCH] glcolorbalance: Copy caps in transform_internal_caps() We don't get ownership of the caps that are passed in, and doing so causes crashes at a later time. Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/546 --- ext/gl/gstglcolorbalance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/gl/gstglcolorbalance.c b/ext/gl/gstglcolorbalance.c index 26c51e8..f448e9b 100644 --- a/ext/gl/gstglcolorbalance.c +++ b/ext/gl/gstglcolorbalance.c @@ -181,7 +181,7 @@ static GstCaps * gcb_transform_internal_caps (GstGLFilter * filter, GstPadDirection direction, GstCaps * caps, GstCaps * filter_caps) { - GstCaps *tmp = gst_caps_make_writable (caps); + GstCaps *tmp = gst_caps_copy (caps); gint i; /* If we're not in passthrough mode, we can only output 2D textures, * but can always receive any compatible texture. -- 2.7.4