From 334b47a082b4e5626f51a99f1ec98bb974c8608f Mon Sep 17 00:00:00 2001 From: "CORP\\mobaswirul.i" Date: Wed, 2 Oct 2024 11:29:02 +0600 Subject: [PATCH] Fix defects detected by static analysis tool [Problem] Issues detected by Static Analysis Tool [Cause & Measure] Cause : No Default Case in switch statements Measure : Added Default Case Change-Id: Ide1d85dd859765a0db5351f886c00a4814c965fa --- music-player/Core/MusicPlayer.cs | 3 +++ music-player/ViewModels/PlayerViewModel.cs | 2 ++ music-player/Views/Utils/ContentViewFactory.cs | 3 +++ music-player/Views/Utils/OperationViewFactory.cs | 7 +++++++ music-player/Views/Utils/SubContentViewFactory.cs | 3 +++ 5 files changed, 18 insertions(+) diff --git a/music-player/Core/MusicPlayer.cs b/music-player/Core/MusicPlayer.cs index 7d4c5a4..b9c0484 100755 --- a/music-player/Core/MusicPlayer.cs +++ b/music-player/Core/MusicPlayer.cs @@ -219,6 +219,9 @@ namespace MusicPlayer.Core case PlayerError.AudioCodecNotSupported: errorDesc = "Audio codec not supported"; break; + default: + errorDesc = "Unknown Error"; + break; } return errorDesc; } diff --git a/music-player/ViewModels/PlayerViewModel.cs b/music-player/ViewModels/PlayerViewModel.cs index 6ad737c..ea6df6e 100755 --- a/music-player/ViewModels/PlayerViewModel.cs +++ b/music-player/ViewModels/PlayerViewModel.cs @@ -355,6 +355,8 @@ namespace MusicPlayer.ViewModels CurrentPlayingTrack.Instance.SetPlayingStatus(false); lyricsViewModel.UpdateTrackThumbState(AnimationState.AnimationPause); break; + default: + break; } } diff --git a/music-player/Views/Utils/ContentViewFactory.cs b/music-player/Views/Utils/ContentViewFactory.cs index 437b22f..aff3b40 100755 --- a/music-player/Views/Utils/ContentViewFactory.cs +++ b/music-player/Views/Utils/ContentViewFactory.cs @@ -50,6 +50,9 @@ namespace MusicPlayer.Views.Utils ArtistView artistView = new ArtistView(artistViewModel); contentView = artistView; break; + default: + Tizen.Log.Warn(AppConstants.LogTag, "No ContentViewType Matched"); + break; } return contentView; } diff --git a/music-player/Views/Utils/OperationViewFactory.cs b/music-player/Views/Utils/OperationViewFactory.cs index f5f5a8a..f4e937d 100755 --- a/music-player/Views/Utils/OperationViewFactory.cs +++ b/music-player/Views/Utils/OperationViewFactory.cs @@ -60,6 +60,9 @@ namespace MusicPlayer.Views.Utils SelectorView removeFromCurrentPlaylistView = new SelectorView(OperationViewType.RemoveFromCurrentPlaylist, removeFromCurrentPlaylistViewModel); view = removeFromCurrentPlaylistView; break; + default: + Tizen.Log.Warn(AppConstants.LogTag, "No OperationViewType Matched"); + break; } return view; } @@ -85,6 +88,8 @@ namespace MusicPlayer.Views.Utils SelectorViewModel artistViewModel = new SelectorViewModel((ListViewModel)viewModelData); deleteView = new SelectorView(OperationViewType.Delete, artistViewModel); break; + default: + break; } return deleteView; } @@ -106,6 +111,8 @@ namespace MusicPlayer.Views.Utils SelectorViewModel artistViewModel = new SelectorViewModel((ListViewModel)viewModelData); addToPlaylistView = new SelectorView(OperationViewType.AddToPlaylist, artistViewModel); break; + default: + break; } return addToPlaylistView; } diff --git a/music-player/Views/Utils/SubContentViewFactory.cs b/music-player/Views/Utils/SubContentViewFactory.cs index 6d32004..7de39ad 100755 --- a/music-player/Views/Utils/SubContentViewFactory.cs +++ b/music-player/Views/Utils/SubContentViewFactory.cs @@ -44,6 +44,9 @@ namespace MusicPlayer.Views.Utils ArtistDetailView artistDetailView = new ArtistDetailView(artistDetailViewModel); subcontentView = artistDetailView; break; + default: + Tizen.Log.Warn(AppConstants.LogTag, "No SubContentViewType Matched"); + break; } return subcontentView; } -- 2.34.1