From 3333cc66436be86f5acefea1449303d2ddeb59ed Mon Sep 17 00:00:00 2001 From: Douglas Yung Date: Thu, 18 Apr 2019 00:00:06 +0000 Subject: [PATCH] Fix test on PS4 which defaults to gnu99 which does not emit the expected warnings. llvm-svn: 358626 --- clang/test/Analysis/security-syntax-checks.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/clang/test/Analysis/security-syntax-checks.c b/clang/test/Analysis/security-syntax-checks.c index 25ce8b1..392a65f 100644 --- a/clang/test/Analysis/security-syntax-checks.c +++ b/clang/test/Analysis/security-syntax-checks.c @@ -1,8 +1,20 @@ // RUN: %clang_analyze_cc1 %s -verify \ // RUN: -analyzer-checker=security.insecureAPI +// RUN: %clang_analyze_cc1 %s -verify -std=gnu11 \ +// RUN: -analyzer-checker=security.insecureAPI +// RUN: %clang_analyze_cc1 %s -verify -std=gnu99 \ +// RUN: -analyzer-checker=security.insecureAPI void builtin_function_call_crash_fixes(char *c) { - __builtin_strncpy(c, "", 6); // expected-warning{{Call to function 'strncpy' is insecure as it does not provide security checks introduced in the C11 standard.}} - __builtin_memset(c, '\0', (0)); // expected-warning{{Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard.}} - __builtin_memcpy(c, c, 0); // expected-warning{{Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard.}} + __builtin_strncpy(c, "", 6); + __builtin_memset(c, '\0', (0)); + __builtin_memcpy(c, c, 0); + +#if __STDC_VERSION__ > 199901 + // expected-warning@-5{{Call to function 'strncpy' is insecure as it does not provide security checks introduced in the C11 standard.}} + // expected-warning@-5{{Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard.}} + // expected-warning@-5{{Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard.}} +#else + // expected-no-diagnostics +#endif } -- 2.7.4