From 31ff034a1eadfd4641ce9c44647e30a759cfbbfb Mon Sep 17 00:00:00 2001 From: Michael Meissner Date: Mon, 12 Jul 2021 23:51:24 -0400 Subject: [PATCH] Fix vec-splati-runnable.c test. I noticed that the vec-splati-runnable.c did not have an abort after one of the tests. If the test was run with optimization, the optimizer could delete some of the tests and throw off the count. However, due to the fact that the value being loaded in that test is undefined, I did not check what value was loaded, but I just stored it into a volatile global variable. 2021-07-12 Michael Meissner gcc/testsuite/ * gcc.target/powerpc/vec-splati-runnable.c: Run test with -O2 optimization. Do not check what XXSPLTIDP generates if the value is undefined. --- .../gcc.target/powerpc/vec-splati-runnable.c | 29 +++++++--------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/gcc/testsuite/gcc.target/powerpc/vec-splati-runnable.c b/gcc/testsuite/gcc.target/powerpc/vec-splati-runnable.c index e84ce77..a135279 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-splati-runnable.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-splati-runnable.c @@ -1,7 +1,7 @@ /* { dg-do run { target { power10_hw } } } */ /* { dg-do link { target { ! power10_hw } } } */ /* { dg-require-effective-target power10_ok } */ -/* { dg-options "-mdejagnu-cpu=power10 -save-temps" } */ +/* { dg-options "-mdejagnu-cpu=power10 -save-temps -O2" } */ #include #define DEBUG 0 @@ -12,6 +12,8 @@ extern void abort (void); +volatile vector double vresult_d_undefined; + int main (int argc, char *argv []) { @@ -85,25 +87,12 @@ main (int argc, char *argv []) #endif } - /* This test will generate a "note" to the user that the argument - is subnormal. It is not an error, but results are not defined. */ - vresult_d = (vector double) { 2.0, 3.0 }; - expected_vresult_d = (vector double) { 6.6E-42f, 6.6E-42f }; - - vresult_d = vec_splatid (6.6E-42f); - - /* Although the instruction says the results are not defined, it does seem - to work, at least on Mambo. But no guarentees! */ - if (!vec_all_eq (vresult_d, expected_vresult_d)) { -#if DEBUG - printf("ERROR, vec_splati (6.6E-42f)\n"); - for(i = 0; i < 2; i++) - printf(" vresult_d[%i] = %e, expected_vresult_d[%i] = %e\n", - i, vresult_d[i], i, expected_vresult_d[i]); -#else - ; -#endif - } + /* This test will generate a "note" to the user that the argument is + subnormal. It is not an error, but results are not defined. Because this + is undefined, we cannot check that any value is correct. Just store it in + a volatile variable so the XXSPLTIDP instruction gets generated and the + warning message printed. */ + vresult_d_undefined = vec_splatid (6.6E-42f); /* Vector splat immediate */ vsrc_a_int = (vector int) { 2, 3, 4, 5 }; -- 2.7.4